[react-interactions] Add Portal propagation configuration #16889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove debugger
|
Oh I'd assigned this task to myself |
necolas
approved these changes
Sep 25, 2019
|
@necolas Ah my bad, sorry about that! Thanks for the review :) |
|
:( I really don't like this approach since it's now no longer safe to convert to and from a portal and it still doesn't solve the problem when you don't use a portal so now you have to convert to a portal to solve it. |
|
@sebmarkbage What approach do you think is better? Happy to revert and take an alternative approach? |
|
There isn't a problem when not using a portal. I'd rather make it so individual portals can be configured to prevent event bubbling but you opposed that too in the existing thread about the issues people had when migrating to the stable createPortal API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Portal propagation configuration support to the new event system. By default responder targets will not propagate through React Portals, unless a
targetPortalPropagationflag is set totrueon the responder object.