Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-interactions] Tap cancels on second pointerdown #16936

Merged
merged 1 commit into from
Oct 1, 2019
Merged

[react-interactions] Tap cancels on second pointerdown #16936

merged 1 commit into from
Oct 1, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Sep 28, 2019

This patch causes onTapCancel to be called whenever a second pointer interacts with the responder target.

@necolas necolas requested a review from trueadm September 28, 2019 00:04
necolas
necolas commented Sep 28, 2019
View reviewed changes
Copy link
Contributor Author

@necolas necolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The isActivePointer checks for moves and releases may no longer be necessary but it needs some unit test coverage.

@sizebot
Copy link

sizebot commented Sep 28, 2019 •
edited
Loading

Details of bundled changes.

Comparing: 2c88320...36de69a

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/focus.development.js 0.0% -0.1% 11.81 KB 11.81 KB 2.57 KB 2.57 KB UMD_DEV
react-interactions-events/press.development.js 0.0% -0.1% 9.02 KB 9.02 KB 2.66 KB 2.66 KB UMD_DEV
react-interactions-events/tap.development.js +2.1% +1.7% 17.8 KB 18.17 KB 3.85 KB 3.92 KB UMD_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 4.31 KB 4.31 KB 1.46 KB 1.46 KB UMD_PROD
react-interactions-events/press.production.min.js 0.0% -0.3% 2.62 KB 2.62 KB 1.09 KB 1.09 KB UMD_PROD
react-interactions-events/tap.production.min.js 🔺+1.4% 🔺+0.5% 6.23 KB 6.31 KB 2.35 KB 2.37 KB UMD_PROD
react-interactions-events/context-menu.development.js 0.0% -0.2% 2.68 KB 2.68 KB 1008 B 1006 B UMD_DEV
react-interactions-events/input.development.js 0.0% -0.2% 4.52 KB 4.52 KB 1.45 KB 1.44 KB UMD_DEV
react-interactions-events/scroll.development.js 0.0% -0.1% 6.3 KB 6.3 KB 1.65 KB 1.65 KB UMD_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.3% 1.39 KB 1.39 KB 730 B 728 B UMD_PROD
react-interactions-events/input.production.min.js 0.0% -0.3% 1.84 KB 1.84 KB 986 B 983 B UMD_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.3% 2.63 KB 2.63 KB 1.15 KB 1.15 KB UMD_PROD
react-interactions-events/context-menu.development.js 0.0% -0.2% 2.49 KB 2.49 KB 962 B 960 B NODE_DEV
react-interactions-events/input.development.js 0.0% -0.2% 4.34 KB 4.34 KB 1.4 KB 1.4 KB NODE_DEV
react-interactions-events/scroll.development.js 0.0% -0.2% 6.12 KB 6.12 KB 1.61 KB 1.61 KB NODE_DEV
react-interactions-accessibility/focus-manager.development.js 0.0% -0.2% 2.76 KB 2.76 KB 1.03 KB 1.03 KB NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.4% 1.2 KB 1.2 KB 670 B 667 B NODE_PROD
react-interactions-events/input.production.min.js 0.0% -0.3% 1.66 KB 1.66 KB 919 B 916 B NODE_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.2% 2.44 KB 2.44 KB 1.09 KB 1.09 KB NODE_PROD
react-interactions-accessibility/focus-manager.production.min.js 0.0% -0.3% 1.27 KB 1.27 KB 713 B 711 B NODE_PROD
react-interactions-events/hover.development.js 0.0% -0.2% 7 KB 7 KB 1.56 KB 1.55 KB UMD_DEV
react-interactions-events/press-legacy.development.js 0.0% -0.0% 24.6 KB 24.6 KB 6.08 KB 6.07 KB UMD_DEV
react-interactions-events/hover.production.min.js 0.0% -0.2% 3.12 KB 3.12 KB 1.13 KB 1.13 KB UMD_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.1% 7.31 KB 7.31 KB 2.77 KB 2.77 KB UMD_PROD
react-interactions-events/hover.development.js 0.0% -0.2% 6.82 KB 6.82 KB 1.51 KB 1.51 KB NODE_DEV
react-interactions-events/press-legacy.development.js 0.0% -0.0% 24.41 KB 24.41 KB 6.02 KB 6.02 KB NODE_DEV
react-interactions-accessibility/focus-table.development.js 0.0% -0.1% 9.27 KB 9.27 KB 1.96 KB 1.95 KB NODE_DEV
react-interactions-accessibility/focus-list.development.js 0.0% -0.1% 5.59 KB 5.59 KB 1.37 KB 1.37 KB NODE_DEV
react-interactions-events/hover.production.min.js 0.0% -0.3% 2.94 KB 2.94 KB 1.08 KB 1.07 KB NODE_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.1% 7.13 KB 7.13 KB 2.71 KB 2.71 KB NODE_PROD
react-interactions-accessibility/focus-table.production.min.js 0.0% -0.2% 2.96 KB 2.96 KB 1.18 KB 1.18 KB NODE_PROD
react-interactions-accessibility/focus-list.production.min.js 0.0% -0.3% 1.92 KB 1.92 KB 912 B 909 B NODE_PROD
react-interactions-events/focus.development.js 0.0% -0.1% 11.63 KB 11.63 KB 2.53 KB 2.53 KB NODE_DEV
react-interactions-events/press.development.js 0.0% -0.0% 8.73 KB 8.73 KB 2.58 KB 2.58 KB NODE_DEV
react-interactions-events/tap.development.js +2.1% +1.7% 17.62 KB 17.99 KB 3.8 KB 3.86 KB NODE_DEV
react-interactions-accessibility/tabbable-scope.development.js 0.0% -0.3% 1.2 KB 1.2 KB 600 B 598 B NODE_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 4.14 KB 4.14 KB 1.4 KB 1.4 KB NODE_PROD
react-interactions-events/press.production.min.js 0.0% -0.3% 2.33 KB 2.33 KB 1.01 KB 1 KB NODE_PROD
react-interactions-events/tap.production.min.js 🔺+1.5% 🔺+1.0% 6.06 KB 6.15 KB 2.3 KB 2.32 KB NODE_PROD
react-interactions-accessibility/tabbable-scope.production.min.js 0.0% -0.5% 662 B 662 B 440 B 438 B NODE_PROD
react-interactions-events/drag.development.js 0.0% -0.2% 5.23 KB 5.23 KB 1.54 KB 1.54 KB UMD_DEV
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.97 KB 5.97 KB 2.24 KB 2.24 KB UMD_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 6 KB 6 KB 1.63 KB 1.62 KB UMD_DEV
react-interactions-events/drag.production.min.js 0.0% -0.2% 2.25 KB 2.25 KB 1.07 KB 1.07 KB UMD_PROD
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.39 KB 2.39 KB 1.21 KB 1.21 KB UMD_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.2% 2.45 KB 2.45 KB 1.11 KB 1.11 KB UMD_PROD
ReactEventsTap-dev.js +2.2% +1.9% 17.53 KB 17.92 KB 3.81 KB 3.88 KB FB_WWW_DEV
ReactEventsTap-prod.js 🔺+2.9% 🔺+1.8% 13.79 KB 14.19 KB 2.98 KB 3.03 KB FB_WWW_PROD
react-interactions-events/keyboard.development.js 0.0% -0.1% 5.79 KB 5.79 KB 2.19 KB 2.19 KB NODE_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 5.82 KB 5.82 KB 1.58 KB 1.58 KB NODE_DEV
react-interactions-accessibility/focus-control.development.js 0.0% -0.1% 4.64 KB 4.64 KB 1.29 KB 1.29 KB NODE_DEV
react-interactions-events/drag.production.min.js 0.0% -0.1% 2.88 KB 2.88 KB 1.38 KB 1.38 KB NODE_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.3% 2.27 KB 2.27 KB 1.05 KB 1.05 KB NODE_PROD
react-interactions-accessibility/focus-control.production.min.js 0.0% -0.1% 1.65 KB 1.65 KB 809 B 808 B NODE_PROD

Generated by 🚫 dangerJS against 36de69a

@necolas
[react-interactions] Tap cancels on second pointerdown
36de69a 
This patch causes onTapCancel to be called whenever a second pointer interacts
with the responder target.
@necolas necolas force-pushed the react-interactions/tap-second-pointer branch from b889a06 to 36de69a Compare October 1, 2019 20:42
@necolas necolas merged commit f6efb22 into facebook:master Oct 1, 2019
@necolas necolas deleted the react-interactions/tap-second-pointer branch December 20, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@necolas @sizebot @trueadm @facebook-github-bot