[EnterLeaveEventPlugin] Fix bug when dealing with unhandled DOM nodes #17006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #16928, where that PR fixed one class of bug, but also introduced another issue whilst doing so.
This PR introduces an alternative fix that avoids the issue introduced in that PR. Notably, when a DOM node has not been handled by React (it hasn't got an internal handle to a fiber), then the target fiber ends up not matching 1:1, meaning the logic in #16928 is not quite accurate as
nativeEventTarget !== fromNodeis a valid code path. This PR fixes it by tracking thenativeEventbetween calls to this EnterLeaveEventPlugin – to ensure we don't duplicate enter events for the same native event object.I've added a test case and validated it fixes the issue internally too.