Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-interactions] Add getInstanceFromNode support to TestHostRenderer #17065

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 11, 2019

This PR adds support for getInstanceFromNode with TestHostRenderer so that we don't get the Not yet implemented. error when using React Scopes using TestRenderer.

@sizebot
Copy link

sizebot commented Oct 11, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 543fad5

@trueadm trueadm force-pushed the scope-test-renderer-support branch from b2423cf to a4beeb4 Compare October 11, 2019 09:46
Fix bad WeakMap key case

Fix bad WeakMap key case
@trueadm trueadm force-pushed the scope-test-renderer-support branch from a4beeb4 to 543fad5 Compare October 11, 2019 09:53
@trueadm trueadm merged commit 0ac8e56 into facebook:master Oct 11, 2019
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
…rer (#17065)

Fix bad WeakMap key case

Fix bad WeakMap key case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants