Test with AppVeyor with Node 11 and 12 #17197
Conversation
|
Hi Saibamen! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
s |
s? |
|
Hi! What is the purpose and motivation for this change? What does it do, or why is it useful? |
|
We need to test it with recent NodeJS LTS version: https://nodejs.org/en/download/ |
|
It usually works with later versions if it passes older versions, so I must ask: what specifically should be tested with newer versions? Is there something that breaks currently? Have you seen issues with other projects that could have been prevented by testing on newer versions? Happy to approve this if there’s a concrete reason. |
Usually ;) |
|
Can we replace AppVeyor with a CircleCI workflow instead? My understanding is that we only use AppVeyor because CircleCI used to not support Windows. But now it does: https://circleci.com/blog/windows-general-availability-announcement/ |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
|
ping |
Test with Node 11 and 12