Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-interactions] Ensure props on scope query function is always Object #17212

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Oct 29, 2019

This PR fixes an issue with React Scopes that I stumbled across with suspense boundaries. This ensures that the scope query function always passes through an object for props.

@sizebot
Copy link

sizebot commented Oct 29, 2019

Size changes (stable)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 784eaf6

@sizebot
Copy link

sizebot commented Oct 29, 2019

Size changes (experimental)

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 784eaf6

@trueadm trueadm merged commit 048879e into facebook:master Oct 29, 2019
@trueadm trueadm deleted the fix-scope-props-issue branch October 29, 2019 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants