[Flight] Move around the Server side a bit #17251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will need to use a variant of Fizz to do inline SSR in Flight. However, I don't want to build the whole impl right now but also don't want to exclude the use case yet. So I outsource it to the existing renderer. Ofc, this doesn't work with Suspense atm.
Size changes (experimental)Details of bundled changes.Comparing: fadc971...b36dfdf react-dom
react-server
|
Size changes (stable)Details of bundled changes.Comparing: fadc971...b36dfdf react-dom
react-server
|
gaearon
reviewed
Nov 2, 2019
| await waitForSuspense(() => { | ||
| expect(result.model).toEqual({ | ||
| html: '<div><span>hello</span><span>world</span></div>', | ||
| }); |
There was a problem hiding this comment.
Mind asserting we actually eventually got here?
There was a problem hiding this comment.
There’s going to be a hundred of these. I’m not going to assert in each one that the testing environment works.
Jest fails it the promise to the test never resolves.
There was a problem hiding this comment.
I mean the promise could resolve without the inner expect actually having run successfully. If there’s a bug in waitForSuspense.
| await waitForSuspense(() => { | ||
| expect(result.model).toEqual({ | ||
| html: '<div><span>hello</span><span>world</span></div>', | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #17234.
Just some clean up before I add more stuff.