-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yarn build --unsafe-partial #17316
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 50925ec:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh this would be very nice!
I think we should still rimraf the specific sub-folders though, so they're not left in a funky state.
You think so? I actually like the entry point granularity. |
The case I'd like to avoid is one of us testing an outdated/unrealistic local So e.g.
I think it would be safer to start with
But I agree with the idea of not Maybe the thing I'm really concerned about is the (unlikely) case that any of us would actually publish to NPM after a partial build- which could be problematic even if we were clearing the package sub-folders, so I dunno... |
Maybe I'll rename to |
Changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our codebase is a minefield, so many "unsafe" thigns 😆
¯\_(ツ)_/¯ Seems fine. Will save some time.
We normally delete the
build
folder when rebuilding for consistency. This can be annoying if I make a tiny scoped edit to a particular package. This is an escape hatch so I can iterate faster when I know what I'm doing.