Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-interactions] Rename Flare listeners prop to DEPRECATED_flareListeners #17394

Merged
merged 1 commit into from
Nov 18, 2019
Merged

[react-interactions] Rename Flare listeners prop to DEPRECATED_flareListeners #17394

merged 1 commit into from
Nov 18, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Nov 18, 2019 •
edited
Loading

This renames the listeners prop to DEPRECATED_flareListeners. This is for two reasons:

  • to discourage internal usage of this experimental API
  • to enable us to experiment with another event API that might make use of the listeners prop in the future

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 18, 2019 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11f9004:

Sandbox Source
dreamy-smoke-7kmhb Configuration

@sizebot
Copy link

sizebot commented Nov 18, 2019 •
edited
Loading

Details of bundled changes.

Comparing: 3ad0764...11f9004

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.46 KB 10.46 KB 3.57 KB 3.57 KB NODE_PROD
react-dom-server.browser.development.js +0.1% +0.2% 136.21 KB 136.37 KB 35.85 KB 35.91 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 953.48 KB 953.92 KB 215.59 KB 215.69 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.87 KB 3.87 KB 1.54 KB 1.54 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 116.18 KB 116.18 KB 37.45 KB 37.45 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.75 KB 119.75 KB 38.56 KB 38.55 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 947.55 KB 947.99 KB 214.01 KB 214.11 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 116.29 KB 116.29 KB 36.86 KB 36.86 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.13 KB 60.13 KB 15.79 KB 15.79 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.04 KB 1.04 KB 634 B 633 B NODE_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.98 KB 119.98 KB 37.87 KB 37.86 KB NODE_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 59.8 KB 59.8 KB 15.66 KB 15.66 KB NODE_DEV
react-dom-server.node.development.js +0.1% +0.2% 137.32 KB 137.48 KB 36.08 KB 36.13 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom-server.browser.development.js +0.1% +0.2% 140.28 KB 140.44 KB 36.85 KB 36.91 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 690 B 689 B NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 19.93 KB 19.93 KB 7.39 KB 7.38 KB UMD_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 11f9004

@sizebot
Copy link

sizebot commented Nov 18, 2019 •
edited
Loading

Details of bundled changes.

Comparing: 3ad0764...11f9004

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% 0.0% 618.21 KB 618.49 KB 131.79 KB 131.85 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 71.65 KB 71.65 KB 21.95 KB 21.95 KB UMD_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 628.98 KB 629.3 KB 130.98 KB 131.05 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.11 KB 39.11 KB 10.01 KB 10.01 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.6 KB 11.6 KB 3.58 KB 3.58 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 33.07 KB 33.07 KB 8.54 KB 8.54 KB NODE_DEV
react-test-renderer.development.js 0.0% 0.0% 613.48 KB 613.76 KB 130.6 KB 130.66 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 71.35 KB 71.35 KB 21.56 KB 21.56 KB NODE_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 123.53 KB 123.53 KB 38.84 KB 38.84 KB NODE_PROFILING
react-dom-server.browser.development.js +0.1% +0.2% 140.3 KB 140.46 KB 36.85 KB 36.91 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.39 KB 20.39 KB 7.48 KB 7.48 KB UMD_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
ReactDOMServer-dev.js +0.1% +0.2% 139.57 KB 139.73 KB 35.4 KB 35.46 KB FB_WWW_DEV
ReactDOMServer-prod.js 🔺+0.3% 🔺+0.5% 48.79 KB 48.91 KB 11.13 KB 11.18 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 953.5 KB 953.95 KB 215.61 KB 215.71 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 119.59 KB 119.59 KB 38.42 KB 38.41 KB UMD_PROD
react-dom.development.js 0.0% 0.0% 947.57 KB 948.01 KB 214.03 KB 214.14 KB NODE_DEV
react-dom-server.node.development.js +0.1% +0.2% 137.35 KB 137.5 KB 36.08 KB 36.14 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 119.73 KB 119.73 KB 37.79 KB 37.79 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.72 KB 20.72 KB 7.61 KB 7.61 KB NODE_PROD
react-dom-server.browser.development.js +0.1% +0.2% 136.24 KB 136.39 KB 35.85 KB 35.91 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.31 KB 20.31 KB 7.46 KB 7.46 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.14 KB 60.14 KB 15.8 KB 15.8 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.73 KB 10.73 KB 3.67 KB 3.67 KB UMD_PROD
ReactDOM-dev.js 0.0% +0.1% 975.63 KB 976.09 KB 216.56 KB 216.67 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 402.36 KB 402.73 KB 73.3 KB 73.37 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 59.82 KB 59.82 KB 15.67 KB 15.66 KB NODE_DEV
ReactDOM-profiling.js +0.1% +0.1% 403.28 KB 403.69 KB 73.85 KB 73.91 KB FB_WWW_PROFILING

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 11f9004

@trueadm trueadm changed the title [react-interactions] Rename Flare listeners prop to DEPRECATED_listeners [react-interactions] Rename Flare listeners prop to DEPRECATED_flareListeners Nov 18, 2019
@trueadm trueadm force-pushed the DEPRECATED_listeners branch from f02e0d7 to 73a412e Compare November 18, 2019 12:22
@trueadm trueadm force-pushed the DEPRECATED_listeners branch from 73a412e to 11f9004 Compare November 18, 2019 12:27
threepointone
threepointone approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for renaming!

@TrySound
Copy link
Contributor

Do you completely reject this api? It looked very good from type system point of view. All low level event listeners could be eliminated in favour of single listeners prop.

@trueadm
Copy link
Contributor Author

trueadm commented Nov 18, 2019

@TrySound We don't necessarily reject the listeners prop and we will likely use something like it again, but with another experimental event system that is different from that of that we have now for React Flare.

@trueadm trueadm merged commit a7d07ff into facebook:master Nov 18, 2019
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
@trueadm
[react-interactions] Rename Flare listeners prop to DEPRECATED_flareL…
af6f895 
…isteners (#17394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threepointone threepointone threepointone approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

@necolas necolas Awaiting requested review from necolas

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trueadm @sizebot @TrySound @threepointone @facebook-github-bot