Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fewer global variables in Hooks #17480

Merged
merged 9 commits into from
Dec 3, 2019
Merged

Use fewer global variables in Hooks #17480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
afc8eee
We don't need the global state for this
sebmarkbage Nov 27, 2019
302610c
Move componentUpdateQueue and sideEffectTag out of global state
sebmarkbage Nov 27, 2019
0d0bc76
Move remainingExpirationTime off global state
sebmarkbage Nov 28, 2019
d4b1793
Move firstWorkInProgressHook off global state
sebmarkbage Nov 28, 2019
0432096
Reset fiber to its current state if it throws
sebmarkbage Nov 28, 2019
3e77742
Move rerender error check to avoid global state
sebmarkbage Nov 28, 2019
cc1aa9d
Move next___Hook out of global state
sebmarkbage Nov 28, 2019
25aa2e5
Assert that currentlyRenderingFiber is always set
sebmarkbage Nov 28, 2019
1ea22f8
Add another test just to be safe
sebmarkbage Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading