Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-interactions] Re-label Flare as deprecated and remove from RN #17644

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Dec 18, 2019

This PR cleans up a bunch of stuff in our code base relating to React Flare. Specifically, it renames all the Flare call-sites to be "DEPRECATED" so it's clear that these APIs are going to go away at some point and shouldn't be used internally. It also removes React Flare from RN – where it was never used internally.

If we are to move forward with other event system experiments, this makes it clearer where the old system (Flare) lives and where other systems live; whereas they might have been confused previously.

@trueadm trueadm force-pushed the deprecated-responder branch from 379fa7c to 5b18eb3 Compare December 18, 2019 10:04
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5b18eb3:

Sandbox Source
cranky-brown-ioyhe Configuration

@sizebot
Copy link

sizebot commented Dec 18, 2019

Details of bundled changes.

Comparing: e84327b...5b18eb3

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js -1.9% -1.9% 744.38 KB 730.21 KB 157.83 KB 154.87 KB RN_OSS_DEV
ReactFabric-prod.js -0.2% -0.2% 266.92 KB 266.43 KB 46.01 KB 45.92 KB RN_OSS_PROD
ReactNativeRenderer-dev.js 0.0% 0.0% 739.38 KB 739.65 KB 157.05 KB 157.11 KB RN_OSS_DEV
ReactFabric-profiling.js -0.2% -0.2% 277.03 KB 276.54 KB 47.87 KB 47.79 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js 0.0% 0.0% 275.22 KB 275.25 KB 47.37 KB 47.38 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 284.16 KB 284.19 KB 49.11 KB 49.11 KB RN_OSS_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.86 KB 19.86 KB 7.38 KB 7.38 KB NODE_PROD
react-dom-test-utils.development.js 0.0% -0.0% 52.73 KB 52.73 KB 14.98 KB 14.98 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 115.77 KB 115.77 KB 37.46 KB 37.46 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.59 KB 60.59 KB 15.99 KB 15.99 KB NODE_DEV
react-dom.profiling.min.js 0.0% -0.0% 119.35 KB 119.35 KB 38.54 KB 38.53 KB UMD_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.96 KB 9.96 KB 3.36 KB 3.36 KB NODE_PROD
react-dom.development.js +0.1% 0.0% 940.91 KB 941.42 KB 213.13 KB 213.23 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 115.88 KB 115.88 KB 36.87 KB 36.87 KB NODE_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.58 KB 119.58 KB 37.82 KB 37.82 KB NODE_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.87 KB 3.87 KB 1.54 KB 1.54 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 703 B 702 B UMD_PROD
react-dom-server.browser.development.js 0.0% 0.0% 137.47 KB 137.52 KB 36.56 KB 36.57 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.7 KB 3.7 KB 1.49 KB 1.49 KB NODE_DEV
react-dom-test-utils.development.js 0.0% -0.0% 54.46 KB 54.46 KB 15.3 KB 15.3 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.04 KB 1.04 KB 634 B 633 B NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-server.browser.development.js 0.0% 0.0% 133.41 KB 133.46 KB 35.54 KB 35.55 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.94 KB 10.94 KB 4.08 KB 4.08 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.89 KB 60.89 KB 16.06 KB 16.06 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 689 B 688 B NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.22 KB 10.22 KB 3.47 KB 3.46 KB UMD_PROD
react-dom-server.node.development.js 0.0% 0.0% 134.52 KB 134.57 KB 35.77 KB 35.78 KB NODE_DEV
react-dom.development.js +0.1% 0.0% 946.84 KB 947.36 KB 214.79 KB 214.88 KB UMD_DEV

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 5b18eb3

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! pending CI success, ship it.

@sizebot
Copy link

sizebot commented Dec 18, 2019

Details of bundled changes.

Comparing: e84327b...5b18eb3

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js 0.0% 0.0% 739.39 KB 739.66 KB 157.06 KB 157.12 KB RN_OSS_DEV
ReactFabric-dev.js -1.9% -1.9% 744.4 KB 730.22 KB 157.83 KB 154.87 KB RN_OSS_DEV
ReactNativeRenderer-dev.js 0.0% 0.0% 739.57 KB 739.84 KB 157.15 KB 157.21 KB RN_FB_DEV
ReactFabric-prod.js -0.2% -0.2% 266.93 KB 266.44 KB 46.02 KB 45.93 KB RN_OSS_PROD
ReactNativeRenderer-prod.js 0.0% 0.0% 275.63 KB 275.66 KB 47.45 KB 47.46 KB RN_FB_PROD
ReactFabric-profiling.js -0.2% -0.2% 277.04 KB 276.55 KB 47.87 KB 47.79 KB RN_OSS_PROFILING
ReactNativeRenderer-profiling.js 0.0% 0.0% 284.56 KB 284.58 KB 49.18 KB 49.19 KB RN_FB_PROFILING
ReactNativeRenderer-prod.js 0.0% 0.0% 275.24 KB 275.27 KB 47.38 KB 47.39 KB RN_OSS_PROD
ReactFabric-dev.js -1.9% -1.9% 744.58 KB 730.41 KB 157.92 KB 154.96 KB RN_FB_DEV
ReactNativeRenderer-profiling.js 0.0% 0.0% 284.17 KB 284.2 KB 49.11 KB 49.12 KB RN_OSS_PROFILING
ReactFabric-prod.js -0.2% -0.2% 267.28 KB 266.79 KB 46.09 KB 46 KB RN_FB_PROD
ReactFabric-profiling.js -0.2% -0.2% 277.39 KB 276.9 KB 47.94 KB 47.86 KB RN_FB_PROFILING

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% -0.0% 123.07 KB 123.07 KB 38.8 KB 38.8 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 137.5 KB 137.55 KB 36.56 KB 36.57 KB UMD_DEV
react-dom-test-utils.development.js 0.0% -0.0% 54.47 KB 54.47 KB 15.31 KB 15.31 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 711 B 710 B UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 52.75 KB 52.75 KB 14.99 KB 14.98 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 642 B 641 B NODE_PROD
react-dom.development.js +0.1% 0.0% 946.86 KB 947.38 KB 214.81 KB 214.9 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 119.12 KB 119.12 KB 38.43 KB 38.43 KB UMD_PROD
react-dom.development.js +0.1% 0.0% 940.93 KB 941.44 KB 213.15 KB 213.25 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 134.54 KB 134.59 KB 35.78 KB 35.78 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 119.27 KB 119.27 KB 37.81 KB 37.81 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 133.43 KB 133.48 KB 35.54 KB 35.55 KB NODE_DEV
ReactDOM-dev.js +0.1% 0.0% 968.6 KB 969.13 KB 215.97 KB 216.07 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 🔺+0.1% 402.69 KB 402.83 KB 73.52 KB 73.56 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.91 KB 60.91 KB 16.07 KB 16.07 KB UMD_DEV
ReactDOM-profiling.js 0.0% +0.1% 403.61 KB 403.75 KB 74.09 KB 74.14 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.23 KB 10.23 KB 3.47 KB 3.47 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.61 KB 60.61 KB 16 KB 15.99 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.97 KB 9.97 KB 3.37 KB 3.37 KB NODE_PROD
ReactDOMServer-dev.js 0.0% 0.0% 139.16 KB 139.21 KB 35.4 KB 35.4 KB FB_WWW_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.21 KB 1.21 KB 698 B 696 B NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against 5b18eb3

@trueadm trueadm merged commit 9fe1031 into facebook:master Dec 18, 2019
@NE-SmallTown
Copy link
Contributor

NE-SmallTown commented Dec 18, 2019

Just curious, would you mind tell a bit about the relationship between this PR and #17508? IMO, just like #17508 said, it learned from react-flare, but seems the new API like unstable_createRootListener is also the API in react-flare? If so, when we deprecate that, is that indicate the experimental Listener API in #17508 has some new thoughts/change? Plz tell me if I'm wrong

@trueadm
Copy link
Contributor Author

trueadm commented Dec 18, 2019

@NE-SmallTown React Flare and the Listener API (as per that other PR) are separate event systems that have entirely different designs. There's some overlap in how things work, but that's more a side-effect of those things being positives taken from React Flare that we want to keep in the future. We are still revising things, so the Listener API PR might also change too, thus why we have not merged it.

@trueadm trueadm deleted the deprecated-responder branch December 18, 2019 11:20
@NE-SmallTown
Copy link
Contributor

Gotcha, thanks~

NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants