Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic GKs for selective/train #17888

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

sebmarkbage
Copy link
Collaborator

There are shipped/shipping.

There are shipped/shipping.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 21, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42dde5b:

Sandbox Source
quirky-easley-v1dd4 Configuration

@sizebot
Copy link

sizebot commented Jan 21, 2020

Details of bundled changes.

Comparing: f2fd484...42dde5b

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.production.min.js 0.0% -0.0% 20.47 KB 20.47 KB 7.5 KB 7.5 KB UMD_PROD
ReactDOMServer-prod.js 0.0% -0.0% 49.02 KB 49.02 KB 11.19 KB 11.19 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% 0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.05 KB 1.05 KB 641 B 642 B NODE_PROD
react-dom.development.js 0.0% 0.0% 956.28 KB 956.28 KB 214.9 KB 214.9 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 119.69 KB 119.69 KB 38.37 KB 38.37 KB UMD_PROD
react-dom.production.min.js 0.0% 0.0% 119.79 KB 119.79 KB 37.64 KB 37.64 KB NODE_PROD
ReactTestUtils-dev.js -0.2% -0.2% 52.37 KB 52.25 KB 14.28 KB 14.25 KB FB_WWW_DEV
ReactDOM-dev.js -0.0% -0.0% 978 KB 977.94 KB 216.12 KB 216.11 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.39 KB 20.39 KB 7.47 KB 7.47 KB NODE_PROD
ReactDOM-prod.js -0.1% -0.2% 394.21 KB 393.84 KB 72.06 KB 71.96 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.2% 405.5 KB 405.14 KB 74.22 KB 74.11 KB FB_WWW_PROFILING
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
ReactDOMServer-dev.js -0.1% -0.1% 139.4 KB 139.28 KB 35.43 KB 35.4 KB FB_WWW_DEV

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 42dde5b

@sizebot
Copy link

sizebot commented Jan 21, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 42dde5b

@gaearon
Copy link
Collaborator

gaearon commented Jan 21, 2020

Do we know if anything got better as a result?

@sebmarkbage sebmarkbage merged commit cf7a0c2 into facebook:master Jan 22, 2020
@sebmarkbage
Copy link
Collaborator Author

@gaearon Marginally for SSR hydration but it turns out to not be the major bottleneck so hard to tell how much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants