Implemented Profiler onCommit() and onPostCommit() hooks #17910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 858c870:
|
Details of bundled changes.Comparing: e1c7e65...858c870 react-dom
react-native-renderer
react-art
react-test-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: e1c7e65...858c870 react-art
react-dom
react-native-renderer
react-test-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: 🔺+0.1% Size changes (experimental) |
bvaughn
force-pushed
the
profiler-commit-durations
branch
from
30358f6
to
26157b4
Compare
|
I have rebased this on top of PR #17947 to pull in the various passive effect fixes. |
sebmarkbage
reviewed
Feb 12, 2020
|
Yes. I've been working on this off and on all afternoon. The recent passive effects changes require changing some of the interaction tracing tests (which I'm working on). Should have it ready to review by tomorrow morning. |
bvaughn
force-pushed
the
profiler-commit-durations
branch
from
26157b4
to
470e4ef
Compare
|
@sebmarkbage rebase complete. Changes to the profiler tests look larger than they are, because I replaced all of the I also updated tests to run with the deferred passive effects flag on and off, so be sure to use the |
bvaughn
commented
Feb 12, 2020
| while (parentFiber !== null) { | ||
| if (parentFiber.tag === Profiler) { | ||
| const parentStateNode = parentFiber.stateNode; | ||
| if (parentStateNode !== null) { |
There was a problem hiding this comment.
This check is something that we wouldn't need to do if we eagerly flushed passive destroy functions during unmount.
ermanzohre
approved these changes
Feb 17, 2020
ermanzohre
approved these changes
Feb 18, 2020
bvaughn
commented
Feb 21, 2020
| describe('onRender callback', () => { | ||
| beforeEach(() => { | ||
| jest.resetModules(); | ||
| [true, false].forEach(deferPassiveEffectCleanupDuringUnmount => { |
There was a problem hiding this comment.
This method of testing feature flags is controversial. I think it's nice to have the extra coverage, and these tests are already very verbose so the idea of duplicating them is not very appealing- but I don't want to die on this hill. I'll remove this and just test one of the flag settings if that's the team preference.
bvaughn
force-pushed
the
profiler-commit-durations
branch
from
470e4ef
to
7c7c918
Compare
|
FYI @sebmarkbage I've added a new feature flag (off by default) called |
bvaughn
force-pushed
the
profiler-commit-durations
branch
from
7c7c918
to
858c870
Compare
sebmarkbage
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new callbacks to the Profiler,
onCommitandonPostCommit, as proposed in RFC 139 (reactjs/rfcs#139).When reviewing, use the
?w=1feature flag to ignore whitespace