Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Expiring a partially completed tree #17926

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Bugfix: Expiring a partially completed tree #17926

merged 3 commits into from
Jan 29, 2020

Commits on Jan 29, 2020

  1. Failing test: Expiring a partially completed tree 

    We should not throw out a partially completed tree if it expires in the
middle of rendering. We should finish the rest of the tree without
yielding, then finish any remaining expired levels in a single batch.
    @acdlite
    acdlite committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    36bf07f View commit details
    Browse the repository at this point in the history

  2. Check if there's a partial tree before restarting 

    If a partial render expires, we should stay in the concurrent path
(performConcurrentWorkOnRoot); we'll stop yielding, but the rest of the
behavior remains the same.

We will only revert to the sync path (performSyncWorkOnRoot) when
starting on a new level.

This approach prevents partially completed concurrent work from
being discarded.
    @acdlite
    acdlite committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    7c100bf View commit details
    Browse the repository at this point in the history

  3. New test: retry after error during expired render

    @acdlite
    acdlite committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    5f7361f View commit details
    Browse the repository at this point in the history