Move MS Windows build to CircleCI #17984
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a09d7cd:
|
| # Fix line endings in Windows. | ||
| command: git config --global core.autocrlf input |
There was a problem hiding this comment.
😑 Do we need to do this if we aren't making any commits? Also, doesn't input really only map to *nix use? (https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration#_code_core_autocrlf_code)
There was a problem hiding this comment.
This was copied from the AppVeyor config. We can try if it works without.
.circleci/config.yml
Outdated
| - run: | ||
| command: yarn install --frozen-lockfile |
| - restore_cache: | ||
| keys: | ||
| - v2-win-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }} | ||
| - v2-win-node-{{ arch }}-{{ .Branch }}- | ||
| - v2-win-node-{{ arch }}- |
There was a problem hiding this comment.
Should this just be - *restore_yarn_cache? Looks like that's what is used elsewhere for this step.
There was a problem hiding this comment.
We are using a different cache key for Win and Linux, since the files and folders might not be exactly the same - so we can't use the same restore step.
.circleci/config.yml
Outdated
| - v2-win-node-{{ arch }}-{{ .Branch }}- | ||
| - v2-win-node-{{ arch }}- | ||
| - run: | ||
| command: nvm install 10.18.1 |
There was a problem hiding this comment.
Looks like 12.x is used on Linux, any reason to use 10.x? (it'll be in maintenance soon)
There was a problem hiding this comment.
10.x is what the AppVeyor config uses, not sure if we should try upgrading?
|
I don't really have much knowledge here. I guess this seems okay? 😄 |
|
I'm reverting this because it slowed our CI times from ~6 minutes to ~23 minutes. That's because it runs the build command without concurrency. Do we really need to run the tests against build? I don't remember why the Windows job exists. Let's figure it out then re-land. |
Do you know who would know? Can we add them to this thread? Seems there are two questions:
|
|
What motivated this change in the first place, @wittgenst? |
|
The goal is to remove the dependency on AppVeyor. |
|
@wittgenst Let's chat on Workplace? Feel free to hit me up and I can give context. |
Revert "Move MS Windows build to CircleCI (facebook#17984)"
Summary
Migrate the MS Windows continuous integration configuration from AppVeyor to CircleCI.
Test Plan
Ran in CircleCI, all workflows succeeded.