Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy www config from Rollup build #18016

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Feb 11, 2020

This PR removes the legacy config setting on our Rollup builds for www bundles. It's been a while since we last investigated the differences between having legacy enabled vs not, as the only visible differences between bundles seems to be the usage of Object.freeze on the export, as shown:

Before:

var React$2 = (Object.freeze || Object)({
  default: React
});

After:

var React$2 = Object.freeze({	
  default: React	
});

The comment in the code from before, "We can't use getters in www.", seems to no longer be relevant too as the getters in the code remain the same between builds.

@trueadm trueadm requested a review from gaearon February 11, 2020 12:15
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 11, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ed2f685:

Sandbox Source
vigilant-cloud-okb97 Configuration

@sizebot
Copy link

sizebot commented Feb 11, 2020

Warnings
⚠️ Base commit is broken: 42918f4

Size changes (stable)

Generated by 🚫 dangerJS against ed2f685

@sizebot
Copy link

sizebot commented Feb 11, 2020

Warnings
⚠️ Base commit is broken: 42918f4

Size changes (experimental)

Generated by 🚫 dangerJS against ed2f685

@trueadm trueadm merged commit 529e58a into facebook:master Feb 11, 2020
@trueadm trueadm deleted the build-legacy-config branch February 11, 2020 13:42
@bvaughn

This comment has been minimized.

@bvaughn

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants