Remove legacy www config from Rollup build #18016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
legacy
config setting on our Rollup builds for www bundles. It's been a while since we last investigated the differences between having legacy enabled vs not, as the only visible differences between bundles seems to be the usage ofObject.freeze
on the export, as shown:Before:
After:
The comment in the code from before, "We can't use getters in www.", seems to no longer be relevant too as the getters in the code remain the same between builds.