Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Modern WWW build #18028

Merged
merged 8 commits into from
Feb 13, 2020
Merged

Add Modern WWW build #18028

merged 8 commits into from
Feb 13, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 12, 2020

Alternative to #18013.

This changes the meaning of release channels for the WWW builds:

  • The stable channel (which was unused) is now the build we ship on WWW.
  • The experimental channel is now used for the new modern build. We won't use it in production yet, but we'll start playing with it. It hard-breaks a bunch of legacy features.

This is unsafe to land until the script is updated to pull in both versions and put them in the right folders. We'll also need to solve the Haste conflicts.

Easier to review individual commits.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 12, 2020
@sizebot
Copy link

sizebot commented Feb 12, 2020 •
edited
Loading

Details of bundled changes.

Comparing: 58b8797...7773be3

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
ReactDOM-dev.js -0.1% -0.1% 990.33 KB 989.59 KB 218.5 KB 218.24 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.21 KB 1.21 KB 712 B 710 B UMD_PROD
react-dom-test-utils.development.js +0.1% +0.1% 55.39 KB 55.46 KB 15.6 KB 15.61 KB UMD_DEV
react-dom-testing.profiling.min.js 0.0% -0.0% 121.42 KB 121.42 KB 38.35 KB 38.35 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% +0.1% 139.32 KB 139.39 KB 36.94 KB 36.96 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 11.21 KB 11.21 KB 4.17 KB 4.17 KB UMD_PROD
react-dom-test-utils.development.js +0.1% +0.1% 53.66 KB 53.73 KB 15.27 KB 15.29 KB NODE_DEV
react-dom-server.browser.development.js 0.0% +0.1% 135.26 KB 135.32 KB 35.92 KB 35.94 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 🔺+0.1% 10.99 KB 10.99 KB 4.1 KB 4.1 KB NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20.39 KB 20.39 KB 7.47 KB 7.47 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 968.93 KB 969.17 KB 217.71 KB 217.76 KB UMD_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.93 KB 60.93 KB 16.08 KB 16.08 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 120 KB 120 KB 38.39 KB 38.39 KB UMD_PROD
ReactTestUtils-dev.js -0.0% -0.1% 52.66 KB 52.65 KB 14.34 KB 14.33 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.25 KB 10.25 KB 3.47 KB 3.47 KB UMD_PROD
ReactDOMServer-dev.js -0.0% -0.0% 140.41 KB 140.39 KB 35.54 KB 35.53 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% -0.0% 123.63 KB 123.63 KB 39.59 KB 39.58 KB UMD_PROFILING
ReactDOMServer-prod.js -1.5% -1.4% 48.99 KB 48.27 KB 11.18 KB 11.02 KB FB_WWW_PROD
react-dom.development.js 0.0% 0.0% 963.01 KB 963.26 KB 216.04 KB 216.09 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.63 KB 60.63 KB 16 KB 16 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 9.99 KB 9.99 KB 3.38 KB 3.38 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 698 B 697 B NODE_PROD
ReactDOM-prod.js -6.0% -6.1% 395.6 KB 371.95 KB 71.89 KB 67.54 KB FB_WWW_PROD
ReactDOM-profiling.js -5.8% -5.9% 406.93 KB 383.25 KB 73.99 KB 69.58 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.05 KB 1.05 KB 643 B 641 B NODE_PROD
react-dom-testing.development.js 0.0% 0.0% 966.35 KB 966.53 KB 216.73 KB 216.76 KB UMD_DEV
react-dom-testing.production.min.js 0.0% -0.0% 117.65 KB 117.65 KB 37.91 KB 37.9 KB UMD_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 989.03 KB 989.2 KB 218.09 KB 218.13 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% 0.0% 121.17 KB 121.17 KB 39.04 KB 39.05 KB UMD_PROFILING
ReactDOMTesting-prod.js 🔺+8.5% 🔺+8.3% 341.24 KB 370.33 KB 62.28 KB 67.47 KB FB_WWW_PROD
react-dom-testing.development.js 0.0% 0.0% 960.43 KB 960.61 KB 215.04 KB 215.07 KB NODE_DEV
ReactDOMTesting-profiling.js +5.2% +5.1% 352.04 KB 370.33 KB 64.23 KB 67.47 KB FB_WWW_PROFILING
react-dom-server.node.development.js 0.0% +0.1% 136.37 KB 136.43 KB 36.15 KB 36.17 KB NODE_DEV
react-dom-testing.production.min.js 0.0% -0.0% 117.75 KB 117.75 KB 37.24 KB 37.23 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.79 KB 20.79 KB 7.62 KB 7.62 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js 0.0% 0.0% 624.68 KB 624.75 KB 128.99 KB 129 KB FB_WWW_DEV
react-art.development.js 0.0% 0.0% 681.2 KB 681.34 KB 146.52 KB 146.55 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 107.54 KB 107.54 KB 32.53 KB 32.53 KB UMD_PROD
react-art.development.js 0.0% 0.0% 611.87 KB 612.01 KB 129.1 KB 129.13 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 72.5 KB 72.5 KB 21.67 KB 21.66 KB NODE_PROD
ReactART-prod.js -3.1% -3.1% 240.07 KB 232.54 KB 40.4 KB 39.16 KB FB_WWW_PROD

ReactDOM: size: 0.0%, gzip: -0.3%

Size changes (experimental)

Generated by 🚫 dangerJS against 7773be3

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 12, 2020 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7773be3:

Sandbox Source
modest-gagarin-detni Configuration

@sizebot
Copy link

sizebot commented Feb 12, 2020 •
edited
Loading

Details of bundled changes.

Comparing: 58b8797...7773be3

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactDOM-profiling.js n/a n/a 0 B 406.91 KB 0 B 73.97 KB FB_WWW_PROFILING
react-dom-testing.production.min.js 0.0% -0.0% 117.22 KB 117.22 KB 37.1 KB 37.09 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.92 KB 60.92 KB 16.07 KB 16.07 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.04 KB 1.04 KB 635 B 633 B NODE_PROD
react-dom-testing.profiling.min.js 0.0% -0.0% 120.9 KB 120.9 KB 38.21 KB 38.2 KB NODE_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.24 KB 10.24 KB 3.46 KB 3.46 KB UMD_PROD
ReactTestUtils-dev.js n/a n/a 0 B 52.65 KB 0 B 14.33 KB FB_WWW_DEV
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 4.4 KB 4.4 KB 1.64 KB 1.64 KB NODE_DEV
react-dom.development.js 0.0% 0.0% 968.91 KB 969.15 KB 217.69 KB 217.75 KB UMD_DEV
react-dom-server.browser.development.js 0.0% +0.1% 139.3 KB 139.36 KB 36.94 KB 36.96 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.2 KB 1.2 KB 690 B 688 B NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 20 KB 20 KB 7.4 KB 7.4 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 119.61 KB 119.61 KB 38.45 KB 38.45 KB UMD_PROFILING
ReactDOMTesting-dev.js n/a n/a 0 B 989.19 KB 0 B 218.12 KB FB_WWW_DEV
ReactDOMFizzServer-dev.js n/a n/a 0 B 4.35 KB 0 B 1.61 KB FB_WWW_DEV
react-dom.development.js 0.0% 0.0% 962.99 KB 963.24 KB 216.03 KB 216.08 KB NODE_DEV
ReactDOMTesting-prod.js n/a n/a 0 B 382.63 KB 0 B 69.52 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% 0.0% 135.23 KB 135.3 KB 35.92 KB 35.93 KB NODE_DEV
ReactDOMFizzServer-prod.js n/a n/a 0 B 2.34 KB 0 B 910 B FB_WWW_PROD
react-dom.production.min.js 0.0% -0.0% 116.15 KB 116.15 KB 36.61 KB 36.61 KB NODE_PROD
react-dom-testing.development.js 0.0% 0.0% 966.33 KB 966.51 KB 216.72 KB 216.75 KB UMD_DEV
ReactDOMTesting-profiling.js n/a n/a 0 B 382.63 KB 0 B 69.52 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.93 KB 19.93 KB 7.39 KB 7.39 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.87 KB 3.87 KB 1.54 KB 1.54 KB UMD_DEV
react-dom.profiling.min.js 0.0% -0.0% 119.82 KB 119.82 KB 37.74 KB 37.74 KB NODE_PROFILING
react-dom-testing.production.min.js 0.0% -0.0% 117.12 KB 117.12 KB 37.76 KB 37.75 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.2 KB 1.2 KB 704 B 702 B UMD_PROD
ReactDOM-dev.js n/a n/a 0 B 990.54 KB 0 B 218.54 KB FB_WWW_DEV
react-dom-testing.profiling.min.js 0.0% 0.0% 120.64 KB 120.64 KB 38.91 KB 38.91 KB UMD_PROFILING
ReactDOMServer-dev.js n/a n/a 0 B 140.38 KB 0 B 35.53 KB FB_WWW_DEV
ReactDOM-prod.js n/a n/a 0 B 395.58 KB 0 B 71.88 KB FB_WWW_PROD
react-dom-testing.development.js 0.0% 0.0% 960.41 KB 960.59 KB 215.03 KB 215.05 KB NODE_DEV
ReactDOMServer-prod.js n/a n/a 0 B 48.98 KB 0 B 11.18 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.7 KB 3.7 KB 1.5 KB 1.49 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.62 KB 60.62 KB 15.99 KB 15.99 KB NODE_DEV
react-dom-test-utils.development.js +0.1% +0.1% 55.38 KB 55.44 KB 15.59 KB 15.61 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 9.98 KB 9.98 KB 3.37 KB 3.37 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 11.2 KB 11.2 KB 4.16 KB 4.16 KB UMD_PROD
ReactDOMUnstableNativeDependencies-dev.js n/a n/a 0 B 59.43 KB 0 B 15.2 KB FB_WWW_DEV
react-dom-test-utils.development.js +0.1% +0.1% 53.65 KB 53.71 KB 15.27 KB 15.29 KB NODE_DEV
ReactDOMUnstableNativeDependencies-prod.js n/a n/a 0 B 25.17 KB 0 B 5.01 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% +0.1% 136.34 KB 136.41 KB 36.14 KB 36.16 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.97 KB 10.97 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% -0.0% 20.34 KB 20.34 KB 7.54 KB 7.54 KB NODE_PROD

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
Scheduler-profiling.js n/a n/a 0 B 17.11 KB 0 B 3.95 KB FB_WWW_PROFILING
SchedulerMock-dev.js n/a n/a 0 B 22.88 KB 0 B 5.44 KB FB_WWW_DEV
SchedulerTracing-dev.js n/a n/a 0 B 9.92 KB 0 B 2.14 KB FB_WWW_DEV
SchedulerMock-prod.js n/a n/a 0 B 11.95 KB 0 B 2.82 KB FB_WWW_PROD
SchedulerTracing-prod.js n/a n/a 0 B 899 B 0 B 425 B FB_WWW_PROD
SchedulerTracing-profiling.js n/a n/a 0 B 6.77 KB 0 B 1.22 KB FB_WWW_PROFILING
scheduler.development.js 0.0% -0.0% 25.28 KB 25.28 KB 6.48 KB 6.48 KB NODE_DEV
scheduler.production.min.js 0.0% -0.0% 4.99 KB 4.99 KB 2 KB 2 KB NODE_PROD
Scheduler-dev.js n/a n/a 0 B 25.72 KB 0 B 6.56 KB FB_WWW_DEV
Scheduler-prod.js n/a n/a 0 B 12.52 KB 0 B 3.05 KB FB_WWW_PROD
scheduler-unstable_mock.production.min.js 0.0% -0.1% 4.71 KB 4.71 KB 1.97 KB 1.97 KB UMD_PROD
scheduler-unstable_mock.development.js 0.0% -0.0% 22.46 KB 22.46 KB 5.35 KB 5.34 KB NODE_DEV
scheduler-tracing.development.js +0.5% +0.7% 11.96 KB 12.03 KB 3.09 KB 3.12 KB NODE_DEV
scheduler-unstable_mock.production.min.js 0.0% -0.1% 4.7 KB 4.7 KB 1.91 KB 1.9 KB NODE_PROD
scheduler-tracing.production.min.js 0.0% -0.3% 728 B 728 B 383 B 382 B NODE_PROD
scheduler-tracing.profiling.min.js 0.0% -0.3% 3.25 KB 3.25 KB 994 B 991 B NODE_PROFILING

react-flight-dom-webpack

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-flight-dom-webpack-server.browser.development.js 0.0% -0.1% 9.3 KB 9.3 KB 3.06 KB 3.06 KB UMD_DEV
react-flight-dom-webpack-server.browser.production.min.js 0.0% -0.2% 2.83 KB 2.83 KB 1.33 KB 1.33 KB UMD_PROD
ReactFlightDOMClient-dev.js n/a n/a 0 B 8.44 KB 0 B 2.51 KB FB_WWW_DEV
ReactFlightDOMClient-prod.js n/a n/a 0 B 6.36 KB 0 B 1.84 KB FB_WWW_PROD
react-flight-dom-webpack-server.node.development.js 0.0% -0.0% 9.99 KB 9.99 KB 3.26 KB 3.26 KB NODE_DEV
react-flight-dom-webpack-server.node.production.min.js 0.0% -0.2% 2.8 KB 2.8 KB 1.28 KB 1.28 KB NODE_PROD
ReactFlightDOMServer-dev.js n/a n/a 0 B 9.97 KB 0 B 3.24 KB FB_WWW_DEV
ReactFlightDOMServer-prod.js n/a n/a 0 B 5.89 KB 0 B 1.75 KB FB_WWW_PROD
react-flight-dom-webpack-server.browser.development.js 0.0% -0.1% 9.09 KB 9.09 KB 3.01 KB 3.01 KB NODE_DEV
react-flight-dom-webpack-server.browser.production.min.js 0.0% -0.1% 2.64 KB 2.64 KB 1.26 KB 1.26 KB NODE_PROD
react-flight-dom-webpack.development.js 0.0% -0.1% 8.7 KB 8.7 KB 2.59 KB 2.59 KB UMD_DEV
react-flight-dom-webpack.production.min.js 0.0% -0.2% 2.87 KB 2.87 KB 1.33 KB 1.33 KB UMD_PROD
react-flight-dom-webpack.development.js 0.0% -0.0% 8.52 KB 8.52 KB 2.55 KB 2.55 KB NODE_DEV
react-flight-dom-webpack.production.min.js 0.0% -0.2% 2.7 KB 2.7 KB 1.27 KB 1.27 KB NODE_PROD

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/context-menu.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 675 B 674 B NODE_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 7.9 KB 7.9 KB 1.66 KB 1.66 KB UMD_DEV
react-interactions-events/press.production.min.js 0.0% -0.4% 2.13 KB 2.13 KB 919 B 915 B NODE_PROD
react-interactions-events/tap.development.js 0.0% -0.0% 18.24 KB 18.24 KB 3.93 KB 3.93 KB UMD_DEV
react-interactions-events/hover.production.min.js 0.0% -0.2% 3.46 KB 3.46 KB 1.22 KB 1.22 KB UMD_PROD
react-interactions-events/tap.production.min.js 0.0% -0.0% 6.34 KB 6.34 KB 2.39 KB 2.39 KB UMD_PROD
ReactEventsKeyboard-dev.js n/a n/a 0 B 5.88 KB 0 B 2.23 KB FB_WWW_DEV
react-interactions-events/focus.development.js 0.0% -0.1% 15.43 KB 15.43 KB 3.21 KB 3.21 KB NODE_DEV
ReactEventsKeyboard-prod.js n/a n/a 0 B 4.03 KB 0 B 1.42 KB FB_WWW_PROD
react-interactions-events/press-legacy.development.js 0.0% -0.0% 23.75 KB 23.75 KB 6.08 KB 6.08 KB NODE_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 5.11 KB 5.11 KB 1.68 KB 1.68 KB NODE_PROD
react-interactions-events/input.development.js 0.0% -0.1% 4.53 KB 4.53 KB 1.45 KB 1.45 KB UMD_DEV
react-interactions-events/press-legacy.production.min.js 0.0% -0.1% 7.09 KB 7.09 KB 2.67 KB 2.67 KB NODE_PROD
react-interactions-events/input.production.min.js 0.0% -0.2% 1.84 KB 1.84 KB 993 B 991 B UMD_PROD
ReactEventsFocus-dev.js n/a n/a 0 B 15.56 KB 0 B 3.26 KB FB_WWW_DEV
ReactEventsPressLegacy-dev.js n/a n/a 0 B 23.48 KB 0 B 5.7 KB FB_WWW_DEV
ReactEventsFocus-prod.js n/a n/a 0 B 11.95 KB 0 B 2.29 KB FB_WWW_PROD
react-interactions-events/input.development.js 0.0% -0.1% 4.34 KB 4.34 KB 1.4 KB 1.4 KB NODE_DEV
ReactEventsPressLegacy-prod.js n/a n/a 0 B 16.84 KB 0 B 3.69 KB FB_WWW_PROD
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.68 KB 2.68 KB 1012 B 1011 B UMD_DEV
react-interactions-events/input.production.min.js 0.0% -0.1% 1.67 KB 1.67 KB 926 B 925 B NODE_PROD
react-interactions-events/press.development.js 0.0% -0.1% 8.21 KB 8.21 KB 2.62 KB 2.62 KB UMD_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.3% 1.39 KB 1.39 KB 736 B 734 B UMD_PROD
react-interactions-events/press.production.min.js 0.0% -0.2% 2.42 KB 2.42 KB 1006 B 1004 B UMD_PROD
ReactEventsInput-dev.js n/a n/a 0 B 4.4 KB 0 B 1.39 KB FB_WWW_DEV
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.49 KB 2.49 KB 966 B 965 B NODE_DEV
ReactEventsInput-prod.js n/a n/a 0 B 3.23 KB 0 B 1.16 KB FB_WWW_PROD
react-interactions-events/press.development.js 0.0% -0.1% 7.92 KB 7.92 KB 2.54 KB 2.54 KB NODE_DEV
ReactEventsContextMenu-dev.js n/a n/a 0 B 2.45 KB 0 B 933 B FB_WWW_DEV
ReactEventsPress-dev.js n/a n/a 0 B 6.8 KB 0 B 1.96 KB FB_WWW_DEV
ReactEventsContextMenu-prod.js n/a n/a 0 B 2.22 KB 0 B 807 B FB_WWW_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 7.72 KB 7.72 KB 1.62 KB 1.62 KB NODE_DEV
ReactEventsPress-prod.js n/a n/a 0 B 4.24 KB 0 B 1.1 KB FB_WWW_PROD
react-interactions-events/tap.development.js 0.0% -0.1% 18.06 KB 18.06 KB 3.88 KB 3.88 KB NODE_DEV
react-interactions-events/hover.production.min.js 0.0% -0.2% 3.29 KB 3.29 KB 1.16 KB 1.16 KB NODE_PROD
react-interactions-events/keyboard.development.js 0.0% -0.0% 6.09 KB 6.09 KB 2.29 KB 2.29 KB UMD_DEV
react-interactions-events/tap.production.min.js 0.0% -0.0% 6.17 KB 6.17 KB 2.35 KB 2.35 KB NODE_PROD
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.43 KB 2.43 KB 1.24 KB 1.24 KB UMD_PROD
ReactEventsHover-dev.js n/a n/a 0 B 7.62 KB 0 B 1.62 KB FB_WWW_DEV
ReactEventsTap-dev.js n/a n/a 0 B 18.02 KB 0 B 3.9 KB FB_WWW_DEV
ReactEventsHover-prod.js n/a n/a 0 B 6.6 KB 0 B 1.46 KB FB_WWW_PROD
react-interactions-events/keyboard.development.js 0.0% -0.0% 5.91 KB 5.91 KB 2.25 KB 2.25 KB NODE_DEV
ReactEventsTap-prod.js n/a n/a 0 B 14.26 KB 0 B 3.05 KB FB_WWW_PROD
react-interactions-events/focus.development.js 0.0% -0.0% 15.61 KB 15.61 KB 3.26 KB 3.26 KB UMD_DEV
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.26 KB 2.26 KB 1.19 KB 1.18 KB NODE_PROD
react-interactions-events/press-legacy.development.js 0.0% -0.0% 23.94 KB 23.94 KB 6.13 KB 6.13 KB UMD_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 5.29 KB 5.29 KB 1.75 KB 1.74 KB UMD_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.1% 7.27 KB 7.27 KB 2.72 KB 2.72 KB UMD_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.production.min.js 0.0% -0.0% 71.91 KB 71.91 KB 21.61 KB 21.61 KB NODE_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 32.42 KB 32.42 KB 8.52 KB 8.52 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.78 KB 11.78 KB 3.7 KB 3.7 KB NODE_PROD
ReactShallowRenderer-dev.js n/a n/a 0 B 34.42 KB 0 B 8.49 KB FB_WWW_DEV
react-test-renderer.development.js 0.0% 0.0% 625.54 KB 625.62 KB 131.85 KB 131.86 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 72.13 KB 72.13 KB 21.94 KB 21.94 KB UMD_PROD
react-test-renderer.development.js 0.0% 0.0% 620.81 KB 620.89 KB 130.67 KB 130.68 KB NODE_DEV
ReactTestRenderer-dev.js n/a n/a 0 B 636.33 KB 0 B 131.49 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 37.88 KB 37.88 KB 9.83 KB 9.83 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.64 KB 11.64 KB 3.59 KB 3.59 KB UMD_PROD

react-is

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-is.development.js 0.0% -0.1% 7.07 KB 7.07 KB 1.89 KB 1.89 KB UMD_DEV
react-is.production.min.js 0.0% -0.1% 2.56 KB 2.56 KB 982 B 981 B UMD_PROD
react-is.development.js 0.0% -0.1% 6.89 KB 6.89 KB 1.84 KB 1.84 KB NODE_DEV
react-is.production.min.js 0.0% -0.2% 2.56 KB 2.56 KB 918 B 916 B NODE_PROD
ReactIs-dev.js n/a n/a 0 B 7.04 KB 0 B 1.88 KB FB_WWW_DEV
ReactIs-prod.js n/a n/a 0 B 5.31 KB 0 B 1.26 KB FB_WWW_PROD

react-refresh

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-refresh-runtime.development.js 0.0% -0.1% 19.13 KB 19.13 KB 5.71 KB 5.71 KB NODE_DEV
react-refresh-runtime.production.min.js 0.0% -0.4% 368 B 368 B 265 B 264 B NODE_PROD
ReactFreshRuntime-dev.js n/a n/a 0 B 19.19 KB 0 B 5.69 KB FB_WWW_DEV
react-refresh-babel.development.js 0.0% -0.0% 24.06 KB 24.06 KB 5.5 KB 5.5 KB NODE_DEV
react-refresh-babel.production.min.js 0.0% -0.0% 7.19 KB 7.19 KB 2.58 KB 2.57 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.production.min.js 0.0% -0.0% 69.98 KB 69.98 KB 20.99 KB 20.99 KB NODE_PROD
react-art.development.js 0.0% 0.0% 681.17 KB 681.32 KB 146.52 KB 146.55 KB UMD_DEV
react-art.production.min.js 0.0% -0.0% 104.98 KB 104.98 KB 31.84 KB 31.84 KB UMD_PROD
react-art.development.js 0.0% 0.0% 611.85 KB 611.99 KB 129.09 KB 129.13 KB NODE_DEV
ReactART-dev.js n/a n/a 0 B 624.74 KB 0 B 128.99 KB FB_WWW_DEV
ReactART-prod.js n/a n/a 0 B 240.05 KB 0 B 40.39 KB FB_WWW_PROD

react-cache

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-cache.production.min.js 0.0% -0.2% 2.19 KB 2.19 KB 1.13 KB 1.12 KB NODE_PROD
react-cache.development.js 0.0% -0.0% 9.81 KB 9.81 KB 3.36 KB 3.36 KB UMD_DEV
react-cache.production.min.js 0.0% -0.1% 2.38 KB 2.38 KB 1.21 KB 1.21 KB UMD_PROD
react-cache.development.js 0.0% -0.0% 9.58 KB 9.58 KB 3.29 KB 3.29 KB NODE_DEV
ReactCache-dev.js n/a n/a 0 B 8.53 KB 0 B 2.79 KB FB_WWW_DEV
ReactCache-prod.js n/a n/a 0 B 5.14 KB 0 B 1.61 KB FB_WWW_PROD

jest-react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
jest-react.production.min.js 0.0% -0.1% 2.54 KB 2.54 KB 1.28 KB 1.28 KB NODE_PROD
jest-react.development.js 0.0% -0.0% 6.67 KB 6.67 KB 2.5 KB 2.49 KB NODE_DEV
JestReact-dev.js n/a n/a 0 B 4.64 KB 0 B 1.72 KB FB_WWW_DEV
JestReact-prod.js n/a n/a 0 B 3.37 KB 0 B 1.25 KB FB_WWW_PROD

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +0.1% +0.1% 114.67 KB 114.73 KB 29.35 KB 29.37 KB UMD_DEV
react.production.min.js 0.0% -0.0% 12.33 KB 12.33 KB 4.84 KB 4.84 KB UMD_PROD
react.profiling.min.js 0.0% -0.0% 15.85 KB 15.85 KB 5.95 KB 5.95 KB UMD_PROFILING
react.development.js +0.1% +0.1% 74.18 KB 74.24 KB 19.64 KB 19.67 KB NODE_DEV
react.production.min.js 0.0% -0.0% 6.54 KB 6.54 KB 2.72 KB 2.72 KB NODE_PROD
React-dev.js n/a n/a 0 B 74.17 KB 0 B 18.83 KB FB_WWW_DEV
React-prod.js n/a n/a 0 B 18.17 KB 0 B 4.69 KB FB_WWW_PROD
React-profiling.js n/a n/a 0 B 18.17 KB 0 B 4.69 KB FB_WWW_PROFILING

ReactDOM: size: 0.0%, gzip: -0.1%

React: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 7773be3

acdlite
acdlite approved these changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me!

@gaearon
Copy link
Collaborator Author

gaearon commented Feb 12, 2020

I’ll prepare a WWW diff for the sync script before merging. Do you have a Haste strategy in mind? We could add package.json that enable separate Haste packages. If I remember how that works correctly.

@acdlite
Copy link
Collaborator

acdlite commented Feb 12, 2020

Hmm I was thinking you'd use requireCond but I can see how that would be tedious to set up for every possible artifact.

@gaearon
Copy link
Collaborator Author

gaearon commented Feb 12, 2020

I mean more that providesModules names (and filenames) need to be unique. Unless you set yo something special like we do for node_modules.

@gaearon gaearon merged commit 8777b44 into facebook:master Feb 13, 2020
@gaearon gaearon deleted the modern-2 branch February 13, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @sizebot @acdlite @facebook-github-bot