[Native] Migrate focus/blur to call TextInputState with the host component #18068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
JoshuaGross
approved these changes
Feb 19, 2020
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Feb 19, 2020
Summary: Test sync of facebook/react#18068 - **[ad84625f8](facebook/react@ad84625f8 )**: [Native] Migrate focus/blur to call TextInputState with the host component (#18068) //<Eli White>// - **[edab5c074](facebook/react@edab5c074 )**: Re-throw errors thrown by the renderer at the root in the complete phase (#18029) //<Andrew Clark>// - **[a6dfe9aa4](facebook/react@a6dfe9aa4 )**: [Native] Delete NativeComponent and NativeMethodsMixin (#18036) //<Eli White>// Changelog: [Changed][General] Partial React Sync from 241c4467...ad84625f8 Reviewed By: mdvacca Differential Revision: D19459322 fbshipit-source-id: daefcf854e3da1c849f8376671065c53a1319ef9
elicwhite
added a commit
to elicwhite/react
that referenced
this pull request
Feb 26, 2020
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Test sync of facebook/react#18068 - **[ad84625f8](facebook/react@ad84625f8 )**: [Native] Migrate focus/blur to call TextInputState with the host component (facebook#18068) //<Eli White>// - **[edab5c074](facebook/react@edab5c074 )**: Re-throw errors thrown by the renderer at the root in the complete phase (facebook#18029) //<Andrew Clark>// - **[a6dfe9aa4](facebook/react@a6dfe9aa4 )**: [Native] Delete NativeComponent and NativeMethodsMixin (facebook#18036) //<Eli White>// Changelog: [Changed][General] Partial React Sync from 241c4467...ad84625f8 Reviewed By: mdvacca Differential Revision: D19459322 fbshipit-source-id: daefcf854e3da1c849f8376671065c53a1319ef9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make focus/blur work for Fabric we need to make event targets be a component instance instead of a react tag.
This PR then updates the Renderer integration with TextInputState to handle instances instead of reactTag.
In order to make that work, we have to have an instance.
This changes the HostComponents, making them pass themselves to TextInputState.
Also added tests.
For Facebook employees:
This PR will need to land and by synced in conjunction with D19458214