Add guard around FocusWithin responder root events #18080
Merged
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
reviewed
Feb 19, 2020
| @@ -36,7 +36,7 @@ type FocusState = { | |||
| isFocused: boolean, | |||
| isFocusVisible: boolean, | |||
| pointerType: PointerType, | |||
| ... | |||
| addedRootEvents?: boolean, | |||
There was a problem hiding this comment.
Does it need to be optional?
There was a problem hiding this comment.
Let's make it just boolean.
There was a problem hiding this comment.
We don't use it in the Focus responder, only the FocusWithin responder. I didn't want to add more code to the state of that responder, so I opted to keep it optional for now. Breaking all the call-sites down by alternative state would make this a far more complex PR.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into an interesting problem internally that is likely due to a strange set of events from the recent
onBeforeBlurchange, causingaddRootEventTypesto try and add the same event before removing it. This change should guard the change to prevent the invariant from occuring in these cases.I'll try and make a repro test tomorrow and see if there's an alternative way to fix this.