Testing builds #18196
Closed
Testing builds #18196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 34baecb:
|
Details of bundled changes.Comparing: 7e83af1...34baecb react
react-dom
Size changes (stable) |
threepointone
force-pushed
the
oss-test-builds
branch
from
8f01a08 to
45f5a6a
Compare
Details of bundled changes.Comparing: 7e83af1...34baecb react-dom
react
ReactDOM: size: n/a, gzip: n/a React: size: 0.0%, gzip: -0.0% Size changes (experimental) |
threepointone
force-pushed
the
oss-test-builds
branch
3 times, most recently
from
c5a591c to
f0102aa
Compare
threepointone
commented
Mar 3, 2020
| @@ -792,7 +790,7 @@ function runActTests(label, render, unmount, rerender) { | |||
| } | |||
| }); | |||
| describe('warn in prod mode', () => { | |||
| it('warns if you try to use act() in prod mode', () => { | |||
| xit('warns if you try to use act() in prod mode', () => { | |||
There was a problem hiding this comment.
I could probably remove this test. Or rewrite it to run across the dev/prod+testing matrix. Thinking about options, not blocking a review.
threepointone
force-pushed
the
oss-test-builds
branch
from
f0102aa to
24b073d
Compare
threepointone
force-pushed
the
oss-test-builds
branch
from
24b073d to
89f7955
Compare
threepointone
force-pushed
the
oss-test-builds
branch
from
89f7955 to
1a15111
Compare
threepointone
commented
Mar 3, 2020
threepointone
force-pushed
the
oss-test-builds
branch
3 times, most recently
from
50ba7e1 to
58400f6
Compare
We removed this in facebook#18138 to unblock 16.13. This PR brings it back, with some changes - - testing builds are prefixed with `unstable-`, i.e - `react-dom/unstable-testing` - added back to `bundles.js` - introduces the `__TESTING__` global. Not used to generate the actual builds, but is used for test specific logic - flushes suspense fallbacks in prod for testing builds - changes tests in TestUtilsAct to reflect this - adds a testing build for `react` as well - and finally removes the testing sigils from prod builds. nice. - misc test config changes
threepointone
force-pushed
the
oss-test-builds
branch
from
58400f6 to
34baecb
Compare
threepointone
commented
Mar 4, 2020
| @@ -962,7 +962,7 @@ function mountEffect( | |||
| ): void { | |||
| if (__DEV__) { | |||
| // $FlowExpectedError - jest isn't a global, and isn't recognized outside of tests | |||
| if ('undefined' !== typeof jest) { | |||
| if (__TESTING__ || 'undefined' !== typeof jest) { | |||
There was a problem hiding this comment.
this will "fix" #15439
threepointone
commented
Mar 4, 2020
| @@ -0,0 +1,10 @@ | |||
| /** | |||
There was a problem hiding this comment.
This file may be unnecessary. 🤔
acdlite
requested changes
Mar 4, 2020
| @@ -789,7 +789,7 @@ function finishConcurrentRender( | |||
| hasNotProcessedNewUpdates && | |||
| // do not delay if we're inside an act() scope | |||
| !( | |||
| __DEV__ && | |||
| (__DEV__ || __TESTING__) && | |||
There was a problem hiding this comment.
We need a plan for all the other warnings. Do we need to update all the other warning guards, too?
There was a problem hiding this comment.
I don’t think we have to change anything?
|
I don’t understand, how would this setup disable warnings? You’d see CI to break badly if that was the case. The act one I modified makes it so the fallback behaviour is the same in prod (but only in testing builds). |
|
Has this been abandoned? I was a bit confused why I didn't get missing act warnings until I found out that these are only enabled for -if ('undefined' !== typeof jest) {
+if (process.env.NODE_ENV === 'test') {which is set by If you still intend to ship extra testing builds (which I prefer over mocking scheduler) I'd like to help. Seems like this PR "only" needs to be updated with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed this in #18138 to unblock 16.13. This PR brings them back, with some changes -
unstable-, i.e -react-dom/unstable-testingbundles.js__TESTING__global. Not used to generate the actual builds, but is used for test specific logic.testingforks ofReactFeatureFlagsreactas well