[Blocks] Make it possible to have lazy initialized and lazy loaded Blocks #18220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocks now initialize lazily.
This is for the case when it's a new Block that hasn't yet initialized. We need to first initialize it to see what "render function" it resolves to so that we can use that in our comparison.
facebook-github-bot
added
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit db9c751:
|
Details of bundled changes.Comparing: fa03206...db9c751 react-dom
react-art
react-reconciler
ReactDOM: size: 0.0%, gzip: 🔺+0.1% Size changes (experimental) |
Details of bundled changes.Comparing: fa03206...db9c751 react-dom
react-art
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
gaearon
approved these changes
Mar 5, 2020
|
The changing of The initialization is unfortunate. There's a lot going on here. We can't throw in child fiber atm because that would bubble to the wrong parent potentially. We would also prevent siblings from warming up. I'm also not happy with the extra tuples created or the "if thennable" type check. It took me like a month to get to this point and I'm still not happy with it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on a similar design as Lazy in #18217
The goal here is to make evaluating the query lazy but still allow render functions from different sources to reconcile against each other - even if they're lazy. In my first approach I hid the lazy loading into the "render" function wrapper which is not going to work since it doesn't reconcile against the same thing anymore then.