Fix email cursor jump #18379
Merged
Fix email cursor jump #18379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl00mber
force-pushed
the
fix-multiple-email-cursor-jump
branch
from
588238f to
c5af268
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 588238f:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 67eff27:
|
Co-authored-by: Peter Potapov <dr.potapoff-peter@yandex.ru>
bl00mber
force-pushed
the
fix-multiple-email-cursor-jump
branch
2 times, most recently
from
1ff10e4 to
ba2b222
Compare
bl00mber
force-pushed
the
fix-multiple-email-cursor-jump
branch
from
ba2b222 to
e9049e7
Compare
bl00mber
force-pushed
the
fix-multiple-email-cursor-jump
branch
from
e9049e7 to
67eff27
Compare
gaearon
approved these changes
Apr 1, 2020
gaearon
added a commit
that referenced
this pull request
Apr 1, 2020
|
I've changed my mind. I think this is possibly more risky. See my comment in #18459. We should definitely fix it but as a part of a more coordinated effort when we can squash many bugs at once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #15418, #14551
Version of React: 16.13.1
Browser: Chrome 80
Previous behavior:
After deleting of second email separated by space cursor jumps to the beginning.
When typing a space in an empty email input and then literal, the space is deleted and cursor jumps to the beginning.
Altered behavior:
Cursor not moving.