Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Not for merge] WWW sync #18381

Closed
wants to merge 5 commits into from
Closed

[Not for merge] WWW sync #18381

wants to merge 5 commits into from

Commits on Mar 24, 2020

  1. Regression test for map() returning an array

    @gaearon
    gaearon committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    344e56c View commit details
    Browse the repository at this point in the history

  2. Add forgotten argument 

    This fixes the bug.
    @gaearon
    gaearon committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    20fc0bd View commit details
    Browse the repository at this point in the history

  3. Remove unused arg and retval 

    These aren't directly observable. The arg wasn't used, it's accidental and I forgot to remove. The retval was triggering a codepath that was unnecessary (pushing to array) so I removed that too.
    @gaearon
    gaearon committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    574ce5d View commit details
    Browse the repository at this point in the history

  4. Flowify ReactChildren

    @gaearon
    gaearon committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    f66dc55 View commit details
    Browse the repository at this point in the history

  5. Revert "Rename internal fields (facebook#18377)" 

    This reverts commit 2ba43ed.
    @gaearon
    gaearon committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    664b936 View commit details
    Browse the repository at this point in the history