Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Not for Merge] Revert "Rename internal fields" #18387

Closed
wants to merge 1 commit into from
Closed

[Not for Merge] Revert "Rename internal fields" #18387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-dom/src/client/ReactDOMComponentTree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ import {getParentSuspenseInstance} from './ReactDOMHostConfig';
const randomKey = Math.random()
.toString(36)
.slice(2);
const internalInstanceKey = '__reactFiber$' + randomKey;
const internalEventHandlersKey = '__reactEvents$' + randomKey;
const internalContainerInstanceKey = '__reactContainer$' + randomKey;
const internalEventListenersKey = '__reactListeners$' + randomKey;
const internalInstanceKey = '__reactInternalInstance$' + randomKey;
const internalEventHandlersKey = '__reactEventHandlers$' + randomKey;
const internalContainerInstanceKey = '__reactContainere$' + randomKey;
const internalEventListenersKey = '__reactEventListeners$' + randomKey;

export function precacheFiberNode(
hostInst: Fiber,
Expand Down
8 changes: 4 additions & 4 deletions packages/shared/ReactInstanceMap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@
* supported we can rename it.
*/
export function remove(key) {
key._reactInternals = undefined;
key._reactInternalFiber = undefined;
}

export function get(key) {
return key._reactInternals;
return key._reactInternalFiber;
}

export function has(key) {
return key._reactInternals !== undefined;
return key._reactInternalFiber !== undefined;
}

export function set(key, value) {
key._reactInternals = value;
key._reactInternalFiber = value;
}