Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset lastEffect when resuming SuspenseList #18412

Merged
merged 1 commit into from
Mar 29, 2020

Commits on Mar 28, 2020

  1. Reset lastEffect when resuming SuspenseList

    We store an effect pointer so we can backtrack in the effect list in some
    cases. This is a stateful variable. If we interrupt a render we need to
    reset it.
    
    This field was added after the optimization was added and I didn't remember
    to reset it here.
    
    Otherwise we end up not resetting the firstEffect so it points to a stale
    list. As a result children don't end up inserted like we think they were.
    Then we try to remove them it errors.
    
    It would be nicer to just get rid of the effect list and use the tree for
    effects instead. Maybe we still need something for deletions tho.
    sebmarkbage committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    a86b002 View commit details
    Browse the repository at this point in the history