Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Refactor commitPlacement to recursively insert nodes (#17996)"" #18540

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Revert "Revert "Refactor commitPlacement to recursively insert nodes (#17996)"" #18540

merged 1 commit into from
Apr 8, 2020

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Apr 8, 2020

Reverts #18517

False alarm. The alert seems unrelated and the timing is a coincidence.

@gaearon gaearon merged commit b225d4f into master Apr 8, 2020
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 8, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9bc6431:

Sandbox Source
delicate-flower-miup7 Configuration

@sizebot
Copy link

sizebot commented Apr 8, 2020

Details of bundled changes.

Comparing: 241103a...9bc6431

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.1% 650.01 KB 650.67 KB 136.49 KB 136.59 KB UMD_DEV
react-art.production.min.js 🔺+0.1% -0.0% 109.61 KB 109.74 KB 33.14 KB 33.13 KB UMD_PROD
react-art.development.js +0.1% +0.1% 553.76 KB 554.4 KB 118.97 KB 119.07 KB NODE_DEV
react-art.production.min.js 🔺+0.2% -0.0% 74.57 KB 74.71 KB 22.33 KB 22.33 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 585.82 KB 586.45 KB 122.96 KB 123.06 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.2% 🔺+0.2% 240.27 KB 240.77 KB 40.56 KB 40.65 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js +0.1% +0.1% 575.09 KB 575.72 KB 121.32 KB 121.41 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 38.72 KB 38.72 KB 9.42 KB 9.43 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 12.74 KB 12.74 KB 3.97 KB 3.97 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 567.73 KB 568.39 KB 118.1 KB 118.2 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 0.0% 74.08 KB 74.17 KB 22.56 KB 22.56 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 541.33 KB 541.96 KB 116.76 KB 116.85 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.2% 🔺+0.4% 73.82 KB 74 KB 22.17 KB 22.25 KB NODE_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.production.min.js 0.0% -0.0% 23.39 KB 23.39 KB 8.6 KB 8.6 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 127.75 KB 127.81 KB 39.9 KB 39.89 KB NODE_PROFILING
ReactDOM-dev.js +0.1% 0.0% 976.75 KB 977.37 KB 216.6 KB 216.7 KB FB_WWW_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.1% 1.2 KB 1.2 KB 704 B 705 B UMD_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 408.24 KB 408.56 KB 73.84 KB 73.9 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 419.06 KB 419.38 KB 75.69 KB 75.75 KB FB_WWW_PROFILING
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.43 KB 4.43 KB 1.55 KB 1.55 KB NODE_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.02 KB 1.02 KB 616 B 617 B NODE_PROD
react-dom-test-utils.development.js 0.0% 0.0% 75.14 KB 75.14 KB 20.11 KB 20.11 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 13.23 KB 13.23 KB 4.9 KB 4.9 KB UMD_PROD
ReactDOMTesting-dev.js +0.1% 0.0% 929.29 KB 929.91 KB 207.06 KB 207.15 KB FB_WWW_DEV
ReactDOMTesting-prod.js 🔺+0.1% 🔺+0.1% 392.88 KB 393.2 KB 71.57 KB 71.65 KB FB_WWW_PROD
ReactDOMTesting-profiling.js +0.1% +0.1% 392.88 KB 393.2 KB 71.57 KB 71.65 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% 0.0% 13.1 KB 13.1 KB 4.81 KB 4.81 KB NODE_PROD
react-dom.development.js +0.1% 0.0% 932.69 KB 933.35 KB 203.56 KB 203.65 KB UMD_DEV
react-dom.production.min.js 0.0% -0.1% 123.58 KB 123.63 KB 39.46 KB 39.42 KB UMD_PROD
ReactDOMForked-dev.js +0.1% 0.0% 976.75 KB 977.37 KB 216.6 KB 216.7 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10 KB 10 KB 3.36 KB 3.36 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 127.41 KB 127.47 KB 40.62 KB 40.63 KB UMD_PROFILING
ReactDOMForked-prod.js 🔺+0.1% 🔺+0.1% 408.24 KB 408.56 KB 73.84 KB 73.9 KB FB_WWW_PROD
react-dom.development.js +0.1% 0.0% 888.12 KB 888.75 KB 201.08 KB 201.17 KB NODE_DEV
ReactDOMForked-profiling.js +0.1% +0.1% 419.06 KB 419.38 KB 75.69 KB 75.75 KB FB_WWW_PROFILING
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.18 KB 5.18 KB 1.7 KB 1.7 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 123.78 KB 123.83 KB 38.63 KB 38.62 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.1% 270.75 KB 270.91 KB 46.54 KB 46.57 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.1% +0.1% 282.13 KB 282.28 KB 48.67 KB 48.74 KB RN_OSS_PROFILING
ReactFabric-prod.js 0.0% -0.0% 262.89 KB 262.89 KB 45.05 KB 45.05 KB RN_OSS_PROD
ReactFabric-dev.js 0.0% 0.0% 637.88 KB 637.88 KB 136.21 KB 136.21 KB RN_FB_DEV
ReactNativeRenderer-dev.js +0.1% +0.1% 653.13 KB 653.75 KB 140.22 KB 140.33 KB RN_OSS_DEV
ReactNativeRenderer-dev.js +0.1% +0.1% 655.53 KB 656.16 KB 140.54 KB 140.65 KB RN_FB_DEV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.1% 270.89 KB 271.05 KB 46.57 KB 46.6 KB RN_FB_PROD
ReactNativeRenderer-profiling.js +0.1% +0.1% 282.27 KB 282.42 KB 48.7 KB 48.77 KB RN_FB_PROFILING

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.58 KB 2.58 KB 1.09 KB 1.09 KB NODE_PROD
react-reconciler.development.js +0.1% +0.1% 595.49 KB 596.12 KB 125.65 KB 125.77 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.1% 🔺+0.1% 79.99 KB 80.08 KB 23.53 KB 23.57 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 9bc6431

@sizebot
Copy link

sizebot commented Apr 8, 2020

Details of bundled changes.

Comparing: 241103a...9bc6431

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.production.min.js 0.0% -0.0% 119.63 KB 119.69 KB 37.53 KB 37.52 KB NODE_PROD
react-dom-test-utils.development.js 0.0% 0.0% 75.12 KB 75.12 KB 20.11 KB 20.11 KB UMD_DEV
ReactDOMTesting-profiling.js +0.1% +0.1% 404.7 KB 405.02 KB 73.38 KB 73.45 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 22.82 KB 22.82 KB 8.48 KB 8.48 KB NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.9 KB 4.9 KB 1.64 KB 1.64 KB UMD_DEV
react-dom.profiling.min.js 0.0% -0.0% 123.49 KB 123.54 KB 38.67 KB 38.66 KB NODE_PROFILING
react-dom-test-utils.production.min.js 0.0% -0.0% 13.22 KB 13.22 KB 4.9 KB 4.89 KB UMD_PROD
react-dom-server.node.development.js 0.0% -0.0% 147.06 KB 147.06 KB 38.88 KB 38.88 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 23.23 KB 23.23 KB 8.65 KB 8.65 KB NODE_PROD
ReactDOMForked-dev.js +0.1% 0.0% 1004.63 KB 1005.25 KB 222.59 KB 222.69 KB FB_WWW_DEV
ReactDOMForked-prod.js 🔺+0.1% 🔺+0.1% 421.15 KB 421.47 KB 75.74 KB 75.8 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.16 KB 5.16 KB 1.69 KB 1.69 KB NODE_DEV
react-dom.development.js +0.1% 0.0% 902.87 KB 903.52 KB 198.28 KB 198.37 KB UMD_DEV
ReactDOMForked-profiling.js +0.1% +0.1% 432.03 KB 432.35 KB 77.63 KB 77.69 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 155 KB 155 KB 39.38 KB 39.38 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.2% 1.16 KB 1.16 KB 659 B 658 B NODE_PROD
react-dom.production.min.js 0.0% 0.0% 119.5 KB 119.55 KB 38.25 KB 38.25 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 22.92 KB 22.92 KB 8.51 KB 8.51 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 123.22 KB 123.27 KB 39.49 KB 39.48 KB UMD_PROFILING
ReactDOMTesting-dev.js +0.1% 0.0% 955.83 KB 956.46 KB 212.67 KB 212.77 KB FB_WWW_DEV
react-dom.development.js +0.1% 0.0% 859.53 KB 860.16 KB 195.81 KB 195.9 KB NODE_DEV
ReactDOMTesting-prod.js 🔺+0.1% 🔺+0.1% 404.7 KB 405.02 KB 73.38 KB 73.45 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 145.85 KB 145.85 KB 38.63 KB 38.63 KB NODE_DEV
ReactDOM-dev.js +0.1% 0.0% 1004.63 KB 1005.25 KB 222.59 KB 222.69 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 421.15 KB 421.47 KB 75.74 KB 75.8 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 432.03 KB 432.35 KB 77.63 KB 77.69 KB FB_WWW_PROFILING
react-dom-test-utils.production.min.js 0.0% 0.0% 13.09 KB 13.09 KB 4.8 KB 4.8 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1 KB 1 KB 608 B 609 B NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 9.98 KB 9.98 KB 3.35 KB 3.35 KB UMD_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.73 KB 9.73 KB 3.25 KB 3.24 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.development.js +0.1% +0.1% 629.74 KB 630.4 KB 132.8 KB 132.89 KB UMD_DEV
react-art.production.min.js 🔺+0.1% 0.0% 107 KB 107.13 KB 32.45 KB 32.46 KB UMD_PROD
react-art.development.js +0.1% +0.1% 534.29 KB 534.92 KB 115.2 KB 115.3 KB NODE_DEV
react-art.production.min.js 🔺+0.2% -0.0% 72.02 KB 72.15 KB 21.67 KB 21.66 KB NODE_PROD
ReactART-dev.js +0.1% +0.1% 595.88 KB 596.51 KB 124.94 KB 125.04 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.2% 🔺+0.2% 247.72 KB 248.21 KB 41.84 KB 41.94 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.1% 567.7 KB 568.36 KB 118.09 KB 118.18 KB UMD_DEV
react-test-renderer.production.min.js 🔺+0.1% 0.0% 74.05 KB 74.15 KB 22.54 KB 22.54 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 38.71 KB 38.71 KB 9.42 KB 9.42 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 0.0% 12.73 KB 12.73 KB 3.96 KB 3.97 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 541.3 KB 541.93 KB 116.75 KB 116.84 KB NODE_DEV
react-test-renderer.production.min.js 🔺+0.2% 🔺+0.4% 73.8 KB 73.97 KB 22.15 KB 22.23 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 575.08 KB 575.71 KB 121.31 KB 121.4 KB FB_WWW_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.1% +0.1% 653.11 KB 653.74 KB 140.21 KB 140.32 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 🔺+0.1% 🔺+0.1% 270.74 KB 270.89 KB 46.53 KB 46.56 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.1% +0.1% 282.11 KB 282.27 KB 48.67 KB 48.73 KB RN_OSS_PROFILING
ReactFabric-dev.js 0.0% 0.0% 635.45 KB 635.45 KB 135.9 KB 135.9 KB RN_OSS_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js +0.1% +0.1% 573.65 KB 574.28 KB 121.37 KB 121.48 KB NODE_DEV
react-reconciler.production.min.js 🔺+0.1% 🔺+0.1% 77.02 KB 77.12 KB 22.83 KB 22.86 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.57 KB 2.57 KB 1.08 KB 1.08 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against 9bc6431

@kassens kassens deleted the revert-18517-revert-placement branch November 29, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @sizebot @facebook-github-bot