Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Build react-dom/server in codesandbox CI #18679

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Apr 20, 2020

Summary

For codesandboxes using PR deploys react-dom/server will be unavailable. This would've been helpful for e.g. #18676

Test Plan

Check if https://codesandbox.io/s/dangerouslysetinnerhtml-undefined-dhs8i?file=/src/index.js works with a build from this PR
Edit: works https://codesandbox.io/s/dangerouslysetinnerhtml-undefined-wxhn5?file=/package.json

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 272d0d0:

Sandbox Source
gracious-lederberg-6xgmp Configuration
dangerouslySetInnerHtml undefined PR

@sizebot
Copy link

sizebot commented Apr 20, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 272d0d0

@sizebot
Copy link

sizebot commented Apr 20, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 272d0d0

@gaearon gaearon merged commit 707478e into facebook:master Apr 20, 2020
@gaearon
Copy link
Collaborator

gaearon commented Apr 20, 2020

thx

@eps1lon eps1lon deleted the patch-1 branch April 20, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants