-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eslint-plugin-react-hooks] useWithoutEffectSuffix fix (#18902) #18907
Merged
gaearon
merged 2 commits into
facebook:master
from
surgeboris:use-without-effect-suffix
May 13, 2020
Merged
[eslint-plugin-react-hooks] useWithoutEffectSuffix fix (#18902) #18907
gaearon
merged 2 commits into
facebook:master
from
surgeboris:use-without-effect-suffix
May 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebook#18902) Since we only reserve `-Effect` suffix, react-hooks/exhaustive-deps is expected to succeed without warning on a custom hook which contains -Effect- in the middle of it's name (but does NOT contain it as a suffix).
surgeboris
changed the title
[eslint-plugin-react-hooks] reproduce bug with a test and fix it (#18902)
[eslint-plugin-react-hooks] useWithoutEffectSuffix fix (#18902)
May 13, 2020
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e200285:
|
gaearon
reviewed
May 13, 2020
gaearon
reviewed
May 13, 2020
packages/eslint-plugin-react-hooks/__tests__/ESLintRuleExhaustiveDeps-test.js
Outdated
Show resolved
Hide resolved
Since we only reserve `-Effect` suffix, react-hooks/exhaustive-deps is expected to succeed without warning on a render helper which contains -use- in the middle of it's name (but does NOT contain it as a prefix, since that would violate hook naming convetion).
surgeboris
force-pushed
the
use-without-effect-suffix
branch
from
May 13, 2020 15:36
2607338
to
e200285
Compare
thanks! |
released in 4.0.2 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to a bug
react-hooks/exhaustive-deps
currently warns whenever name contains-Effect-
(even if it does NOT contain it as a suffix).Since we only reserve
-Effect
suffix, react-hooks/exhaustive-deps isexpected to succeed without warning on a custom hook which contains
-Effect-
inthe middle of it's name (but does NOT contain it as a suffix).
Test Plan
Added a testcase that fails when fix isn't present:
Once fix is added test succeeds: