Docs/Tutorial: Introducing a submit button in the comment form #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seiffert thanks for this! You're totally right. I added it in the committed example but didn't update the docs: https://github.com/petehunt/react-tutorial/blob/master/scripts/example.js |
petehunt
added a commit
that referenced
this pull request
May 30, 2013
Docs/Tutorial: Introducing a submit button in the comment form
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Nov 12, 2013
fix title case for tips everywhere
georgesisco
added a commit
to georgesisco/react
that referenced
this pull request
Apr 9, 2014
… steps The following steps also have an ajax function, but the 'error:' param is gone after facebook#13: facebook#14 facebook#17 facebook#19 facebook#20 This may be superfluous, but it helped me find an error with something I was doing - Namely, in my .json file, I had single line javascript comments ("//") that I copied from the tutorial. I couldn't find the issue on later steps, but was able to see my issue when the error handler complained about an unexpected "/" in my file in step facebook#13.
zpao
pushed a commit
that referenced
this pull request
May 8, 2014
The following steps also have an ajax function, but the 'error:' param is gone after #13: #14 #17 #19 #20 This may be superfluous, but it helped me find an error with something I was doing - Namely, in my .json file, I had single line javascript comments ("//") that I copied from the tutorial. I couldn't find the issue on later steps, but was able to see my issue when the error handler complained about an unexpected "/" in my file in step #13.
chenglou
added a commit
to chenglou/react
that referenced
this pull request
Jun 26, 2014
chenglou
added a commit
that referenced
this pull request
Jun 26, 2014
(cherry picked from commit dbf41a5)
chenglou
added a commit
that referenced
this pull request
Jun 26, 2014
chenglou
added a commit
that referenced
this pull request
Jun 27, 2014
chenglou
added a commit
that referenced
this pull request
Jun 27, 2014
(cherry picked from commit 5ba3911)
Merged
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds a submit button to the tutorial's comment form.
A form has to either contain a submit button or an
actionattribute to be 'submittable' by pressing enter. IMO, the only other way to achieve this is to manually listen for keyboard events, which was implied by the tutorial but not included in the example source code.