fix(eslint-plugin-react-hooks): Support nullish coalescing and optional chaining of dependencies #19008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #18985
Summary
In conditions where optional chaining is used inside the
useEffect
hook, thereact-hooks/exhaustive-deps
rule falsely flags missing dependencies. This change adds some logic to the linting rules to also match dependencies with optional chaining.Test Plan
Have added tests to cover the following valid scenarios that were previously failing: