Effects list refactor #19261
Closed
Effects list refactor #19261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fed95cf:
|
Details of bundled changes.Comparing: 61dd00d...fed95cf react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
Details of bundled changes.Comparing: 61dd00d...fed95cf react-dom
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
sebmarkbage
reviewed
Jul 7, 2020
bvaughn
force-pushed
the
effects_list_refactor
branch
from
2d01fb4
to
1033552
Compare
gaearon
reviewed
Jul 7, 2020
packages/react-native-renderer/src/__tests__/createReactNativeComponentClass-test.internal.js
Outdated
Show resolved
Hide resolved
sebmarkbage
reviewed
Jul 7, 2020
sebmarkbage
reviewed
Jul 7, 2020
bvaughn
force-pushed
the
effects_list_refactor
branch
from
0cad81a
to
162a805
Compare
bvaughn
commented
Jul 9, 2020
bvaughn
force-pushed
the
effects_list_refactor
branch
from
41cb193
to
f0669de
Compare
bvaughn
commented
Jul 9, 2020
bvaughn
force-pushed
the
effects_list_refactor
branch
2 times, most recently
from
5579f7b
to
5cfe800
Compare
added 6 commits
July 11, 2020 12:43
Process deletions as we traverse the tree during commit, before we process other effects. This has the result of better mimicking the previous sequencing.
bvaughn
force-pushed
the
effects_list_refactor
branch
from
5cfe800
to
fed95cf
Compare
sebmarkbage
reviewed
Jul 15, 2020
|
|
||
| commitBeforeMutationEffectOnFiber(current, nextEffect); | ||
| if (fiber.sibling !== null) { | ||
| commitBeforeMutationEffects(fiber.sibling); |
There was a problem hiding this comment.
It's unusually to have very deep trees but it's not that unusual to have a few hundred of items in a list. This could cause a stack overflow in that case. We should probably keep the while loop for siblings but not for the recursive effects.
It doesn't even have to be a particularly long list. 10th child inside the 10th child inside the 10th child etc.
sebmarkbage
approved these changes
Jul 16, 2020
|
Already merged via #19322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is phase one of a planned effects list refactor. It includes the following changes:
deletionsFiber field.subtreeTagmask field to optimize traversal during commit phase.All unit tests pass in this branch, although one or two required some slight tweaking.
This PR specifically does not include the following refactor pieces:
firstEffect,lastEffect, andnextEffect).subtreeTagfield.Additional follow up work:
wasFiberClonedheuristic.Co-authored-by: Luna Ruan luna@fb.com