-
Notifications
You must be signed in to change notification settings - Fork 46.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevTools] Show HOC names in profiler #19283
[DevTools] Show HOC names in profiler #19283
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84ad4f2:
|
cce5986
to
5cb363d
Compare
5cb363d
to
e3530ab
Compare
@jyash97 my method of passing the value may be better, however your idea with badges seems interesting. The color of badges on your video is indistinguishable from the blocks on which they are placed: maybe they need to be rendered white. If it will be considered appropriate by react developers I may integrate badges to this PR with your credit. |
@bl00mber I agree the way you are passing the values is way better than I did as I wasnt aware of the full codebase so I did what I could figure out. We can wait for brian or other react team members for the next steps here. Thanks for looking into the PR. 😁 |
I will review both in the morning. I believe I have an initial preference for the UI shown on this PR but we'll see when I dig in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig it. Thanks~
close #19259
related #18802