Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining references to effect list #19673

Merged
merged 2 commits into from
Aug 22, 2020
Merged

Remove remaining references to effect list #19673

merged 2 commits into from
Aug 22, 2020

Commits on Aug 21, 2020

  1. Remove firstEffect null check 

    This is the last remaining place where the effect list has semantic
implications.

I've replaced it with a check of `effectTag` and `subtreeTag`, to see
if there are any effects in the whole tree. This matches the semantics
of the old check. However, I think only reason this optimization exists
is because it affects profiling. We should reconsider whether this
is necessary.
    @acdlite
    acdlite committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    8821965 View commit details
    Browse the repository at this point in the history

  2. Remove remaining references to effect list 

    We no longer use the effect list anywhere in our implementation. It's
been replaced by a recursive traversal in the commit phase.

This removes all references to the effect list in the new fork.
    @acdlite
    acdlite committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    22ea70e View commit details
    Browse the repository at this point in the history