Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gate pragma instead of if (__EXPERIMENTAL__) #19722

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Aug 28, 2020

Found this block when reading useOpaqueIdentifier tests

@acdlite acdlite requested a review from lunaruan August 28, 2020 20:29
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f6004cf:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Aug 28, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against f6004cf

@sizebot
Copy link

sizebot commented Aug 28, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against f6004cf

@acdlite
Copy link
Collaborator Author

acdlite commented Aug 28, 2020

Ah I see when an error is thrown in ReactDOMServer.renderToNodeStream, it crashes the wholes suite. So the negative tests don't work.

Never mind then, don't care enough to fix this right now.

@acdlite acdlite closed this Aug 28, 2020
@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Aug 28, 2020
Added an error listener so that the tests fail within their Jest scope,
instead of crashing the whole process.
@acdlite
Copy link
Collaborator Author

acdlite commented Aug 28, 2020

I figured it out

@acdlite acdlite merged commit 4f5fb56 into facebook:master Aug 28, 2020
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
* Use gate pragma instead of if (__EXPERIMENTAL__)

* Fix stream error handling in tests

Added an error listener so that the tests fail within their Jest scope,
instead of crashing the whole process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants