Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix button links on bottom of home #2

Merged
merged 1 commit into from
May 29, 2013

Conversation

paulshen
Copy link
Contributor

The buttons on the index were pointing at wrong paths.

@yungsters
Copy link
Contributor

Looks good, thanks for fixing!

yungsters added a commit that referenced this pull request May 29, 2013
[docs] Fix button links on bottom of home
@yungsters yungsters merged commit 5ec4542 into facebook:master May 29, 2013
@yungsters yungsters deleted the homebuttons branch May 29, 2013 20:32
petehunt added a commit that referenced this pull request Jun 19, 2013
zpao pushed a commit that referenced this pull request Jun 19, 2013
jimfb added a commit that referenced this pull request Nov 26, 2014
Warn if context values differ, related to issue #2
jimfb pushed a commit that referenced this pull request Apr 8, 2015
Update ReactDOMIframe-test.js
aickin added a commit to aickin/react that referenced this pull request Oct 25, 2015
…s a result of issue facebook#2. Still TODO: change documentation and do some sanity perf testing to make sure that streaming isn't impacted by the code flow changes.
gaearon pushed a commit that referenced this pull request May 10, 2016
Fix code-style issue with React guidelines
@milesj milesj mentioned this pull request Aug 3, 2016
lacker pushed a commit that referenced this pull request Oct 21, 2016
* remove old docs framey stuff

* css tweak, tutorial rename, scrap old stuff

* fix the tutorial links

* broken link

* a slew of broken links

* all broken links up to the tips

* redirects for all the tips

* fix up prev/next links

* fix error decoder

* remove old folder

* move addons to reference

* Split Lists and Conditional Rendering (#2)

* Split Lists and Conditional Rendering

* Update lists-and-keys.md

* move around some redirects

* point to hello world rather than installation

* tweak hello world text

* make docs header point to hello world
KyleAMathews pushed a commit to KyleAMathews/react that referenced this pull request Jul 2, 2017
yu-tian113 added a commit to yu-tian113/react that referenced this pull request Nov 13, 2017
# This is the 1st commit message:

Issue facebook#11257 - compare files/folders in package/npm to "files" in package.json, only copy whitelisted files/folders to build (+1 squashed commit)
Squashed commits:
[d400198] handle directories in files list - e.g. "libs/" (+1 squashed commit)
Squashed commits:
[52a4d3b] Add in file check to make sure all entry points have equivalent files in ./npm folder.
Fail the build if any equivalent missing. (+1 squashed commit)
Squashed commits:
[e2d1516] Update glob to exclude *.fb.js, replace the check in if statement (+1 squashed commit)
Squashed commits:
[b4ddd28] Code refactor as per peer review. (+2 squashed commits)
Squashed commits:
[854373f] Remove the else after the hard exit, make the code after unintended.
[e97dff1] Update to handle patterns in 'files' field, terminate the build if entry point not whitelisted, terminate the build if 'files' field is missing from package.json

# This is the commit message facebook#2:

Remove the else after the hard exit, make the code after unintended.
klamping added a commit to klamping/react that referenced this pull request Mar 9, 2018
@sebmarkbage sebmarkbage mentioned this pull request Feb 11, 2019
11 tasks
bvaughn added a commit that referenced this pull request Aug 15, 2019
Fix encoding of Unicode keys greater than U+00FF
smagill referenced this pull request in smagill/react Dec 20, 2019
Update error codes

fix lint

DCE

fix test

Add event kinds to help propagation rules

Add event kinds to help propagation rules #2

Fix kind bug

cleanup

Address feedback

Fix flow

Major refactor and re-design

More revisions

Cleanup

Cleanup 2

Add DCE and unmounting logic for host instances
josephsavona pushed a commit that referenced this pull request May 15, 2024
…ferenced

identifiers 

--- 

A few fixes for finding context identifiers: 

Previously, we counted every babel identifier as a reference. This is 
problematic because babel counts every string symbol as an identifier. 

```js 

print(x);  // x is an identifier as expected 

obj.x      // x is.. also an identifier here 

{x: 2}     // x is also an identifier here 

``` 

This PR adds a check for `isReferencedIdentifier`. Note that only non-lval 
references pass this check 

```js 

print(x);  // isReferencedIdentifier(x) -> true 

obj.x      // isReferencedIdentifier(x) -> false 

{x: 2}     // isReferencedIdentifier(x) -> false 

x = 2      // isReferencedIdentifier(x) -> false 

``` 

Which brings us to change #2. 

Previously, we counted assignments as references due to the identifier visiting 
+ checking logic. The logic was roughly the following (from #1691) 

```js 

contextVars = intersection(reassigned, referencedByInnerFn); 

``` 

Now that assignments (lvals) and references (rvals) are tracked separately, the 
equivalent logic is this. Note that assignment to a context variable does not 
need to be modeled as a read (`console.log(x = 5)` always will evaluates and 
prints 5, regardless of the previous value of x). 

``` 

contextVars = union(reassignedByInnerFn, intersection(reassigned, 
referencedByInnerFn)) 

``` 

--- 

Note that variables that are never read do not need to be modeled as context 
variables, but this is unlikely to be a common pattern. 

```js 

function fn() { 

let x = 2; 

const inner = () => { 

x = 3; 

} 

} 

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants