Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added failing tests for mutable source mutate during render #20199

Closed
wants to merge 1 commit into from
Closed

Added failing tests for mutable source mutate during render #20199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion packages/react-reconciler/src/__tests__/useMutableSource-test.internal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ function loadModules() {
jest.useFakeTimers();

ReactFeatureFlags = require('shared/ReactFeatureFlags');

ReactFeatureFlags.enableSchedulerTracing = true;
ReactFeatureFlags.enableProfilerTimer = true;

React = require('react');
ReactNoop = require('react-noop-renderer');
Scheduler = require('scheduler');
Expand Down Expand Up @@ -1718,6 +1718,39 @@ describe('useMutableSource', () => {
});
});

// See https://github.com/facebook/react/issues/19948
it('should recover from mutations during read', () => {
const source = createSource('initial');
const mutableSource = createMutableSource(source, param => param.version);

function MutateDuringRead() {
const value = useMutableSource(
mutableSource,
defaultGetSnapshot,
defaultSubscribe,
);
Scheduler.unstable_yieldValue('MutateDuringRead:' + value);
// This is not a supported/recommended pattern.
if (value === 'initial') {
source.value = 'updated';
}
return null;
}

act(() => {
ReactNoop.renderLegacySyncRoot(
<React.StrictMode>
<MutateDuringRead />
</React.StrictMode>,
);
});

expect(Scheduler).toHaveYielded([
'MutateDuringRead:initial',
'MutateDuringRead:updated',
]);
});

if (__DEV__) {
describe('dev warnings', () => {
// @gate experimental
Expand Down