Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning if return pointer is inconsistent #20219

Merged
merged 1 commit into from
Nov 11, 2020

Commits on Nov 11, 2020

  1. Add warning if return pointer is inconsistent

    Bugs caused by inconsistent return pointers are tricky to diagnose
    because the source of the error is often in a different part of the
    codebase from the actual mistake. For example, you might forget to set a
    return pointer during the render phase, which later causes a crash in
    the commit phase.
    
    This adds a dev-only invariant to the commit phase to check for
    inconsistencies. With this in place, we'll hopefully catch return
    pointer errors quickly during local development, when we have the most
    context for what might have caused it.
    acdlite committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    0610a94 View commit details
    Browse the repository at this point in the history