Unwind cycles reconciler fiber lanes #20256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eactInternalTypes. Necessitates making the Lane types non-opaque, very difficult to disentangle otherwise.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f580128:
|
Details of bundled changes.Comparing: 765e89b...f580128 react-dom
react-native-renderer
react-test-renderer
react-art
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (experimental) |
Details of bundled changes.Comparing: 765e89b...f580128 react-dom
react-native-renderer
react-test-renderer
react-art
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following #20242, this PR untangles a slightly more elaborate cycle. In order to do so, I needed to make the types
Lane,Lanes,LaneMap, andLanePriorityinto non-opaque types, which may go against their intent. Open to suggestions if there's a cleaner way to remove the cycle betweenReactFiberLaneandReactInternalTypesthat preserves the opaque tag.Cycle detection
I used a tool called
madgeto detect cyclical imports. This change brings the number of cycles in thepackages/react-reconcilerpackage down from 50 to 48.This eliminates the following cycles:
Test Plan
Since this change only affects the location of a type and constant definitions, there shouldn't be any need to add or change tests.