Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Placement bit without removing others #20398

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Add Placement bit without removing others #20398

merged 1 commit into from
Dec 7, 2020

Commits on Dec 7, 2020

  1. Add Placement bit without removing others 

    When scheduling a Placement effect, we should add the Placement bit
without resetting the others.

In the old fork, there are no flags to reset, anyway, since by the
time we reach the child reconciler, the flags will have already been
reset.

However, in the effects refactor, "static" flags are not reset, so this
can actually manifest as a bug. See facebook#20285 for a regression test.
    @acdlite
    acdlite committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    a040878 View commit details
    Browse the repository at this point in the history