Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining tests to combined workflow #20577

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jan 12, 2021

No description provided.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 12, 2021
@sizebot
Copy link

sizebot commented Jan 12, 2021

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 3ed789b

@sizebot
Copy link

sizebot commented Jan 12, 2021

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 3ed789b

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ed789b:

Sandbox Source
React Configuration

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're doing this sequentially but while I'm thinking about it here's a few more things for us to migrate:

  • DevTools tests and build script rely on the old structure
  • Our scripts/releases does as well

@acdlite acdlite merged commit b99ac3d into facebook:master Jan 12, 2021
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants