Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prod build in ci/codesandbox #20606

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jan 17, 2021

Summary

Currently deploying a prod build from a codesandbox using a PR fails due to scheduler/unstable_no_dom not being built in codesandbox/ci.

codesandbox using #20604: https://codesandbox.io/s/react-forked-grtg9?file=/src/App.js
build failure: https://vercel.com/eps1lon/csb-grtg9/r7r8rfpwn

Test Plan

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 09b8fa9:

Sandbox Source
React Configuration
React (forked) PR

@sizebot
Copy link

sizebot commented Jan 17, 2021

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 09b8fa9

@sizebot
Copy link

sizebot commented Jan 17, 2021

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 09b8fa9

@eps1lon eps1lon marked this pull request as ready for review January 17, 2021 14:48
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@rickhanlonii rickhanlonii merged commit 9a21507 into facebook:master Jan 18, 2021
@eps1lon eps1lon deleted the test/deployable-pr-csb branch January 19, 2021 09:00
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants