Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release script --commit param #20720

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Fix release script --commit param #20720

merged 1 commit into from
Feb 3, 2021

Commits on Feb 3, 2021

  1. Fix release script --commit param 

    PR facebook#20717 accidentally broke the `--commit` parameter because the
script errors if you provide both a `--build` and a `--commit`.

I solved by removing the validation error. When there's a conflict, it
will choose the --`build`.

(Although maybe we should `--build` entirely and always uses `--commit`.
I think `--commit` is a sufficient replacement.)
    @acdlite
    acdlite committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    65b3132 View commit details
    Browse the repository at this point in the history