Explain where to provide the key for dynamic children. #2097
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
|
||
| ```javascript | ||
| // WRONG! | ||
| let ListItemWrapper = React.createClass({ |
There was a problem hiding this comment.
I like ES6 as much as the next guy, but we're sticking to "var" in our docs for now. ;)
|
Just a few small things – otherwise looks great, thanks! |
|
@fitzgen Want to update and we'll ship this? |
|
Ah sorry, got busy and this fell off the radar. Will update in a second. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
fitzgen
force-pushed
the
explain-where-to-provide-key
branch
from
906d10f to
18874a6
Compare
Explain where to provide the key for dynamic children.
|
Thanks @fitzgen! I'll sync this out with the next site update (today or tomorrow) |
Explain where to provide the key for dynamic children.
@spicyj