Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document prerequisites for download-experimental-build #21005

Merged
merged 3 commits into from
Mar 15, 2021

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Mar 15, 2021

Summary

Following

To use the latest build from CI, run the following command from the root of the repository:
```sh
./scripts/release/download-experimental-build.js
```
./scripts/release/download-experimental-build.js is not runnable since it's not mentioned that one has the install the nested workroot first.

Test Plan

  • Steps work in Ubuntu 20.04
  • CI green

@eps1lon eps1lon changed the title Make download-experimental-build runnable Document prerequisites for download-experimental-build Mar 15, 2021
@sizebot
Copy link

sizebot commented Mar 15, 2021

Comparing: f227e7f...d2bbb86

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.83 kB 122.83 kB = 39.52 kB 39.52 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.33 kB 129.33 kB = 41.59 kB 41.58 kB
facebook-www/ReactDOM-prod.classic.js = 408.70 kB 408.70 kB = 75.80 kB 75.80 kB
facebook-www/ReactDOM-prod.modern.js = 396.96 kB 396.96 kB = 73.86 kB 73.86 kB
facebook-www/ReactDOMForked-prod.classic.js = 408.71 kB 408.71 kB = 75.80 kB 75.80 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against d2bbb86

@eps1lon eps1lon marked this pull request as ready for review March 15, 2021 09:20
@bvaughn bvaughn merged commit 00d4f95 into facebook:master Mar 15, 2021
@bvaughn bvaughn deleted the chore/fix-release-download branch March 15, 2021 13:48
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants