Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] Expose a method to abort a pending request #21027

Merged
merged 5 commits into from
Mar 18, 2021
Merged

[Fizz] Expose a method to abort a pending request #21027

merged 5 commits into from
Mar 18, 2021

Commits on Mar 18, 2021

  1. Track all suspended work while it's still pending 

    This allows us to abort work and put everything into client rendered mode
if we don't want to wait for further I/O.

It also allows us to cancel fallbacks if we complete the main content
before the fallback.
    @sebmarkbage
    sebmarkbage committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    08146f1 View commit details
    Browse the repository at this point in the history

  2. Expose abort API to the browser streams 

    Since this API already returns a value, we need to use destructuring to
expose more options.
    @sebmarkbage
    sebmarkbage committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    6bc8670 View commit details
    Browse the repository at this point in the history

  3. Add a test including the client actually client rendering it

    @sebmarkbage
    sebmarkbage committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    5d8cdc8 View commit details
    Browse the repository at this point in the history

  4. Use AbortSignal option for W3C streams instead of external control

    @sebmarkbage
    sebmarkbage committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    ab84723 View commit details
    Browse the repository at this point in the history

  5. Clean up listener after it's used once

    @sebmarkbage
    sebmarkbage committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    28c0533 View commit details
    Browse the repository at this point in the history