Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] Expose callbacks in options for when various stages of the content is done #21056

Merged
merged 4 commits into from
Mar 23, 2021
Merged

[Fizz] Expose callbacks in options for when various stages of the content is done #21056

merged 4 commits into from
Mar 23, 2021

Commits on Mar 23, 2021

  1. Report errors to a global handler 

    This allows you to log errors or set things like status codes.
    @sebmarkbage
    sebmarkbage committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    7ed3e5a View commit details
    Browse the repository at this point in the history

  2. Add complete callback

    @sebmarkbage
    sebmarkbage committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    4d22b70 View commit details
    Browse the repository at this point in the history

  3. onReadyToStream callback 

    This is typically not needed because if you want to stream when the
root is ready you can just start writing immediately.
    @sebmarkbage
    sebmarkbage committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    0509b57 View commit details
    Browse the repository at this point in the history

  4. Rename onComplete -> onCompleteAll

    @sebmarkbage
    sebmarkbage committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    b28626f View commit details
    Browse the repository at this point in the history