Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Was previously "Fix HAS_POSITIVE_NUMERIC_VALUE properties" — code and title updated to fix underlying problem]
The bitmask checks in
DOMProperty
do not properly handle masks with more than one bit set; specifically, properties markedHAS_NUMERIC_VALUE
are also passing tests forHAS_POSITIVE_NUMERIC_VALUE
, introduced in 5c9d616.This bug manifests when attempting to use the
start
attribute on an ordered list to make the list start at 0. The following test case (also available on JSFiddle demonstrates):The output of the above is: