Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush discrete passive effects before paint #21150

Merged
merged 1 commit into from
Mar 31, 2021

Commits on Mar 31, 2021

  1. Flush discrete passive effects before paint

    If a discrete render results in passive effects, we should flush them
    synchronously at the end of the current task so that the result is
    immediately observable. For example, if a passive effect adds an event
    listener, the listener will be added before the next input.
    
    We don't need to do this for effects that don't have discrete/sync
    priority, because we assume they are not order-dependent and do not
    need to be observed by external systems.
    
    For legacy mode, we will maintain the existing behavior, since it hasn't
    been reported as an issue, and we'd have to do additional work to
    distinguish "legacy default sync" from "discrete sync" to prevent all
    passive effects from being treated this way.
    acdlite committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    52a7680 View commit details
    Browse the repository at this point in the history