Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary type cast #21363

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Apr 27, 2021

Summary

Increases type coverage from 82.50% to 82.66% 💪 ...

... just because we got rid of one expression.

$ git checkout master
$ npx flow coverage packages/react-dom/src/client/ReactDOMLegacy.js
Covered: 82.50% (429 of 520 expressions)

$ git checkout eps1lon/chore/root-coverage
$ npx flow coverage packages/react-dom/src/client/ReactDOMLegacy.js 
Covered: 82.66% (429 of 519 expressions)

TODO comment was added in 1b55ad2. The flow bug was likely fixed during an update to flow since the type didn't change in the meantime.

Test Plan

  • CI green

@eps1lon

This comment has been minimized.

@eps1lon

This comment has been minimized.

@eps1lon eps1lon marked this pull request as ready for review April 27, 2021 09:46
@eps1lon

This comment has been minimized.

@sizebot
Copy link

sizebot commented Apr 27, 2021

Comparing: 9a25916...1b4bb4f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.76 kB 122.76 kB = 39.42 kB 39.42 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.34 kB 129.34 kB = 41.51 kB 41.51 kB
facebook-www/ReactDOM-prod.classic.js = 406.92 kB 406.92 kB = 75.31 kB 75.31 kB
facebook-www/ReactDOM-prod.modern.js = 394.95 kB 394.95 kB = 73.41 kB 73.41 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.92 kB 406.92 kB = 75.31 kB 75.32 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1b4bb4f

@bvaughn bvaughn merged commit 29faeb2 into facebook:master Apr 27, 2021
@bvaughn bvaughn deleted the chore/root-coverage branch April 27, 2021 16:37
@bvaughn
Copy link
Contributor

bvaughn commented Apr 27, 2021

Thanks!

koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants