[Fizz] Let value override defaultValue if both are specified #21369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a DEV warning for this case but we still test for the production behavior.
facebook-github-bot
added
React Core Team
gaearon
approved these changes
Apr 27, 2021
sebmarkbage
commented
Apr 27, 2021
| break; | ||
| default: | ||
| pushAttribute(target, responseState, propKey, propValue); | ||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (checked !== null) { |
There was a problem hiding this comment.
Why this instead of props.checked? Well because we have to do the loop and check every property name anyway. Where as props.checked likely wouldn't be fast pathed since the hidden class of these props are often different. So it would be an unnecessary map look up. However, I do a props.id check below but that's just because I expect that code path to go away.
|
Comparing: 9a25916...379f853 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
There's a DEV warning for this case but we still test for the production behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a DEV warning for this case but we still test for the production behavior.
It's a bit annoying since it might be more efficient to just rely on the loop and iteration order. I was almost ready to die on this hill but not quite.